Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtins: 3.5 -> 4.0 #38208

Merged
merged 1 commit into from Sep 24, 2018
Merged

libtins: 3.5 -> 4.0 #38208

merged 1 commit into from Sep 24, 2018

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/libtins/versions.

These checks were done:

  • built on NixOS
  • Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
  • found 4.0 with grep in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0
  • found 4.0 in filename of file in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0
  • directory tree listing: https://gist.github.com/26990576c9472ca38b4d21613157856b

cc @fdns for review

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/libtins/versions.

These checks were done:

- built on NixOS
- Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
- found 4.0 with grep in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0
- found 4.0 in filename of file in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0
- directory tree listing: https://gist.github.com/26990576c9472ca38b4d21613157856b
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: libtins

Partial log (click to expand)

         55 - dot11/reassoc_request (Child aborted)
         56 - dot11/reassoc_response (Child aborted)
         57 - dot11/rts (Child aborted)
         58 - radiotap (Child aborted)
         59 - wep_decrypt (Child aborted)
         60 - wpa2_decrypt (Child aborted)
Errors while running CTest
make: *** [Makefile:84: test] Error 8
builder for '/nix/store/cm763si1jigrw84my6lii72zmqvsx1qp-libtins-4.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/cm763si1jigrw84my6lii72zmqvsx1qp-libtins-4.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libtins

Partial log (click to expand)

-- Installing: /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0/include/tins/sniffer.h
-- Installing: /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0/include/tins/tcp_stream.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0
shrinking /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0/lib/libtins.so.4.0
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0/lib
patching script interpreter paths in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0
checking for references to /build in /nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0...
/nix/store/izz1bkj35g5bb6kvqa5kqgb376xhardg-libtins-4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libtins

Partial log (click to expand)

-- Installing: /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0/include/tins/sniffer.h
-- Installing: /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0/include/tins/tcp_stream.h
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0
shrinking /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0/lib/libtins.so.4.0
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0/lib
patching script interpreter paths in /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0
checking for references to /build in /nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0...
/nix/store/8qsi6ln7nhpfbcj7zrx7jcgsn8vc61vr-libtins-4.0

@fdns
Copy link
Contributor

fdns commented Mar 31, 2018

Updating libtins to v4.0 will be a major version change, and will break the package compactor. There is a branch working in the update, but I would prefer the change be merged in master before updating.

@obadz
Copy link
Contributor

obadz commented May 12, 2018

@GrahamcOfBorg build compactor

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: compactor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: compactor

Partial log (click to expand)

                 from src/baseoutputwriter.cpp:15:
src/dnsmessage.hpp: At global scope:
src/dnsmessage.hpp:174:16: error: cannot declare field 'DNSMessage::dns' to be of abstract type 'CaptureDNS'
     CaptureDNS dns;
                ^~~
make[1]: *** [Makefile:1436: src/compactor-baseoutputwriter.o] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:1059: all] Error 2
builder for '/nix/store/0r5brbfhm4dzk09nfzr5s97xjfjraipi-compactor-0.11.0.drv' failed with exit code 2
error: build of '/nix/store/0r5brbfhm4dzk09nfzr5s97xjfjraipi-compactor-0.11.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: compactor

Partial log (click to expand)

                 from src/baseoutputwriter.cpp:15:
src/dnsmessage.hpp: At global scope:
src/dnsmessage.hpp:174:16: error: cannot declare field 'DNSMessage::dns' to be of abstract type 'CaptureDNS'
     CaptureDNS dns;
                ^~~
make[1]: *** [Makefile:1436: src/compactor-baseoutputwriter.o] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:1059: all] Error 2
builder for '/nix/store/ja8csig0f8ld515nn33a8ilnbd3d3061-compactor-0.11.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/ja8csig0f8ld515nn33a8ilnbd3d3061-compactor-0.11.0.drv' failed

@Ekleog
Copy link
Member

Ekleog commented Sep 24, 2018

@fdns ping from triage: I read your answer as implying that you know some changes that would make this update work. Is this correct? If so, do you know how to move this forward?

@fdns fdns mentioned this pull request Sep 24, 2018
9 tasks
@fdns
Copy link
Contributor

fdns commented Sep 24, 2018

@Ekleog Sorry for the delay, I submitted #47271 with the update to compator, which add support to libtins 4.0 (I tested it locally and should work without problems)

@Ekleog
Copy link
Member

Ekleog commented Sep 24, 2018

@fdns No problem, and thank you for actually doing it! 👍 So if I understand correctly, #47271 should be merged first, then this one? :)

@fdns
Copy link
Contributor

fdns commented Sep 24, 2018

@Ekleog Yes, as the previous compactor doesn't support libtins 4.0

@xeji
Copy link
Contributor

xeji commented Sep 24, 2018

now this should work:
@GrahamcOfBorg build compactor

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: compactor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: compactor

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1
shrinking /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1/bin/inspector
shrinking /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1/bin/compactor
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1/bin
patching script interpreter paths in /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1
checking for references to /build in /nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1...
/nix/store/lldiwdlww4m8p3rnhvkdi0q654vpb9ad-compactor-0.11.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: compactor

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1
shrinking /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1/bin/inspector
shrinking /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1/bin/compactor
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1/bin
patching script interpreter paths in /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1
checking for references to /build in /nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1...
/nix/store/4dw7vrr0zjhqplc71abhlcyx7aws12ns-compactor-0.11.1

@xeji xeji merged commit 39443c6 into NixOS:master Sep 24, 2018
@r-ryantm r-ryantm deleted the auto-update/libtins branch October 3, 2018 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants