Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some errors in std.io #877

Merged
merged 1 commit into from Mar 31, 2018
Merged

Fix some errors in std.io #877

merged 1 commit into from Mar 31, 2018

Conversation

raulgrell
Copy link
Contributor

Fix undeclared identifier error in readUntilDelimiterBuffer and incorrect number of parameters in readUntilDelimiterAlloc

@raulgrell
Fix undeclared identifier error in readUntilDelimiterBuffer and incor…
b57f06e 
…rect number of parameters in readUntilDelimiterAlloc
andrewrk
andrewrk approved these changes Mar 31, 2018
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm going to add a unit test before merging.

@raulgrell
Copy link
Contributor Author

I figured there was no need since it was essentially a typo =)

I'll keep an eye out for any more std lib functions that don't have tests

@andrewrk
Copy link
Member

Yeah, you know, this is fine. We can do some test coverage analysis on the stdlib before 1.0.0.

@andrewrk andrewrk merged commit eb6ff79 into ziglang:master Mar 31, 2018
@andrewrk
Copy link
Member

thanks!

@raulgrell raulgrell deleted the stdlib branch April 2, 2018 19:02
@raulgrell raulgrell restored the stdlib branch April 2, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raulgrell @andrewrk