hangups: 0.4.4 #38255

aswan89 · 2018-03-31T19:52:27Z

Motivation for this change

Addition of hangups application/library and required dependencies to nixpkgs.
Allows use of Google hangouts in terminal.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

FRidh

Please also check the contribution guidelines regarding the naming of commits.

FRidh · 2018-04-01T06:06:05Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

@@ -0,0 +1,59 @@
+{ pkgs, stdenv, python3 }:


Don't pass in pkgs

FRidh · 2018-04-01T06:06:37Z

pkgs/development/python-modules/ReParser/default.nix

+    sha256 = "0nniqb69xr0fv7ydlmrr877wyyjb61nlayka7xr08vlxl9caz776";
+  };
+
+  name = "${pname}-${version}";


The name attribute is added by buildPython* and should therefore be removed.

FRidh · 2018-04-01T06:06:48Z

pkgs/development/python-modules/readlike/default.nix

+    inherit pname version;
+    sha256 = "1ck65ycw51f4xnbh4sg9axgbl81q3azpzvd5f2nvrv2fla9m8r08";
+  };
+  name = "${pname}-${version}";


The name attribute is added by buildPython* and should therefore be removed.

FRidh · 2018-04-01T06:07:52Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

@@ -0,0 +1,59 @@
+{ pkgs, stdenv, python3 }:
+let 
+  packageOverrides = self: super:{


dotlambda · 2018-04-03T10:02:02Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

+  };
+  pythonPackages = (python3.override { inherit packageOverrides;}).pkgs;
+
+in python3.pkgs.buildPythonApplication rec {


pythonPackages

dotlambda · 2018-04-03T10:02:19Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

+      };
+    }); 
+  };
+  pythonPackages = (python3.override { inherit packageOverrides;}).pkgs;


Please add a space after ;

dotlambda · 2018-04-03T10:02:44Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

+    sha256 = "1sm8c9mfcdyhlb6k2cq1r4j3zpc4z47z7zs8yycmf45nmv0vg0h9";
+  };
+
+  doCheck = true;


not necessary, is set automatically

dotlambda · 2018-04-03T10:05:12Z

@GrahamcOfBorg build python2.pkgs.readlike python3.pkgs.readlike python2.pkgs.ReParser python3.pkgs.ReParser hangups

GrahamcOfBorg · 2018-04-03T10:06:32Z

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.readlike, python3.pkgs.readlike, python2.pkgs.ReParser, python3.pkgs.ReParser, hangups

Partial log (click to expand)

writing top-level names to hangups.egg-info/top_level.txt
reading manifest file 'hangups.egg-info/SOURCES.txt'
writing manifest file 'hangups.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
�[31;1merror:�[0m build of '/nix/store/yn0512lk1gcw535za7v9qzj2gklga7zj-python2.7-ReParser-1.4.3.drv' failed

GrahamcOfBorg · 2018-04-03T10:10:22Z

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.readlike, python3.pkgs.readlike, python2.pkgs.ReParser, python3.pkgs.ReParser, hangups

Partial log (click to expand)

writing top-level names to hangups.egg-info/top_level.txt
reading manifest file 'hangups.egg-info/SOURCES.txt'
writing manifest file 'hangups.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.001s

OK
�[31;1merror:�[0m build of '/nix/store/1mn9qw0zlrillcmbg9djyrniwkx9nan7-python2.7-ReParser-1.4.3.drv' failed

dotlambda · 2018-04-03T10:15:50Z

I think you need to set disabled = !isPy3k for ReParser.

dotlambda · 2018-04-04T16:51:48Z

@GrahamcOfBorg build python2.pkgs.readlike python3.pkgs.readlike python3.pkgs.ReParser hangups

GrahamcOfBorg · 2018-04-04T16:54:32Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.readlike, python3.pkgs.readlike, python3.pkgs.ReParser, hangups

Partial log (click to expand)

running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/rxjymrsla65igw2zjpp31az8zksjbb8l-python2.7-readlike-0.1.2
/nix/store/nrxqrjjfszga3fgd2dfrmbwvinfp4avs-python3.6-readlike-0.1.2
/nix/store/b5p4y4r8751byzxn6d91ap1yd4wla2lh-python3.6-ReParser-1.4.3
/nix/store/1n794p4bj9mh2r589n9rbdfcgi8544kh-hangups-0.4.4

GrahamcOfBorg · 2018-04-04T16:56:36Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.readlike, python3.pkgs.readlike, python3.pkgs.ReParser, hangups

Partial log (click to expand)

running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.001s

OK
/nix/store/6vxqa24d85skh0lzscixz65miaxnwv9r-python2.7-readlike-0.1.2
/nix/store/86kdrz90wiv1zbsb5pgl51dcbr219hsx-python3.6-readlike-0.1.2
/nix/store/ggvjnrb1r1jml0i10dqgr0x1i33gl21m-python3.6-ReParser-1.4.3
/nix/store/l19jlz0w8ad023pi4mnhg1xcz2f4r38m-hangups-0.4.4

dotlambda · 2018-04-04T17:01:33Z

Ran 0 tests in 0.000s

Please add appropriate checkPhases.

added explicit check phase

dotlambda · 2018-04-07T21:46:56Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

+    python3 setup.py check --metadata --restructuredtext --strict
+  '';
+
+  doCheck = true;


dotlambda · 2018-04-07T21:47:14Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

+    sha256 = "1sm8c9mfcdyhlb6k2cq1r4j3zpc4z47z7zs8yycmf45nmv0vg0h9";
+  };
+
+  checkInputs = [ 


please use with pythonPackages

dotlambda · 2018-04-07T21:48:11Z

@GrahamcOfBorg build python2.pkgs.readlike python3.pkgs.readlike python3.pkgs.ReParser hangups

GrahamcOfBorg · 2018-04-07T21:48:28Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.readlike, python3.pkgs.readlike, python3.pkgs.ReParser, hangups

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/gyyxhn0gz00fwqhfsqv5cw1a798sp366-hangups-0.4.4/lib  /nix/store/gyyxhn0gz00fwqhfsqv5cw1a798sp366-hangups-0.4.4/bin
patching script interpreter paths in /nix/store/gyyxhn0gz00fwqhfsqv5cw1a798sp366-hangups-0.4.4
checking for references to /tmp/nix-build-hangups-0.4.4.drv-0 in /nix/store/gyyxhn0gz00fwqhfsqv5cw1a798sp366-hangups-0.4.4...
wrapping `/nix/store/gyyxhn0gz00fwqhfsqv5cw1a798sp366-hangups-0.4.4/bin/hangups'...
running install tests
running check
/nix/store/rxjymrsla65igw2zjpp31az8zksjbb8l-python2.7-readlike-0.1.2
/nix/store/nrxqrjjfszga3fgd2dfrmbwvinfp4avs-python3.6-readlike-0.1.2
/nix/store/b5p4y4r8751byzxn6d91ap1yd4wla2lh-python3.6-ReParser-1.4.3
/nix/store/gyyxhn0gz00fwqhfsqv5cw1a798sp366-hangups-0.4.4

GrahamcOfBorg · 2018-04-07T21:52:55Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.readlike, python3.pkgs.readlike, python3.pkgs.ReParser, hangups

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/3jd18yhfrqma0vklm6kznr06b4qqid93-hangups-0.4.4/lib  /nix/store/3jd18yhfrqma0vklm6kznr06b4qqid93-hangups-0.4.4/bin
patching script interpreter paths in /nix/store/3jd18yhfrqma0vklm6kznr06b4qqid93-hangups-0.4.4
checking for references to /build in /nix/store/3jd18yhfrqma0vklm6kznr06b4qqid93-hangups-0.4.4...
wrapping `/nix/store/3jd18yhfrqma0vklm6kznr06b4qqid93-hangups-0.4.4/bin/hangups'...
running install tests
running check
/nix/store/6vxqa24d85skh0lzscixz65miaxnwv9r-python2.7-readlike-0.1.2
/nix/store/86kdrz90wiv1zbsb5pgl51dcbr219hsx-python3.6-readlike-0.1.2
/nix/store/ggvjnrb1r1jml0i10dqgr0x1i33gl21m-python3.6-ReParser-1.4.3
/nix/store/3jd18yhfrqma0vklm6kznr06b4qqid93-hangups-0.4.4

dotlambda · 2018-04-07T21:49:35Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

+
+  meta = with stdenv.lib; {
+    description = "The first third-party instant messaging client for Google Hangouts";
+    homepage = http://github.com/tdryer/hangups;


dotlambda · 2018-04-07T21:54:25Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

+  };
+
+  checkInputs = [ 
+    pythonPackages.docutils


probably not needed

dotlambda · 2018-04-07T21:54:41Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

+  ];
+
+  checkPhase = ''
+    python3 setup.py check --metadata --restructuredtext --strict


That doesn't really test anything. Something like

checkPhase = '' py.test '';

should work. However, you'll need to use fetchFromGitHub as the tests are not included in the PyPI tarball.

dotlambda · 2018-04-07T21:56:04Z

pkgs/development/python-modules/readlike/default.nix

+    inherit pname version;
+    sha256 = "1ck65ycw51f4xnbh4sg9axgbl81q3azpzvd5f2nvrv2fla9m8r08";
+  };
+


checkPhase needed

dotlambda · 2018-04-07T21:56:29Z

pkgs/development/python-modules/ReParser/default.nix

+    inherit pname version;
+    sha256 = "0nniqb69xr0fv7ydlmrr877wyyjb61nlayka7xr08vlxl9caz776";
+  };
+


Please set doCheck = false and add a comment that there are no tests.

dotlambda · 2018-04-07T22:08:59Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

+    ReParser
+    appdirs
+    urwid
+    protobuf3_1


Please use protobuf and pin the version as for the packages above. You'll have to use

protobuf = super.protobuf.override { protobuf = protobuf3_1; };

however and add protobuf3_1 as an argument.

aswan89 requested a review from FRidh as a code owner March 31, 2018 19:52

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 31, 2018

FRidh requested changes Apr 1, 2018

View reviewed changes

pythonPackages.readlike: init at 0.1.2

da57cd4

dotlambda requested changes Apr 3, 2018

View reviewed changes

pythonPackages.ReParser: init at 1.4.3

246bd12

hangups: init at 0.4.4

5381162

added explicit check phase

dotlambda requested changes Apr 7, 2018

View reviewed changes

dotlambda reviewed Apr 7, 2018

View reviewed changes

wmertens changed the title ~~Hangups added~~ hangups: 0.4.4 Apr 8, 2018

dotlambda added the 2.status: work-in-progress label May 10, 2018

aswan89 closed this Aug 2, 2018

aswan89 deleted the hangups-added branch August 2, 2018 19:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hangups: 0.4.4 #38255

hangups: 0.4.4 #38255

aswan89 commented Mar 31, 2018

FRidh left a comment

FRidh Apr 1, 2018

FRidh Apr 1, 2018

FRidh Apr 1, 2018

FRidh Apr 1, 2018

dotlambda Apr 3, 2018

dotlambda Apr 3, 2018

dotlambda Apr 3, 2018

dotlambda commented Apr 3, 2018

GrahamcOfBorg commented Apr 3, 2018

GrahamcOfBorg commented Apr 3, 2018

dotlambda commented Apr 3, 2018

dotlambda commented Apr 4, 2018

GrahamcOfBorg commented Apr 4, 2018

GrahamcOfBorg commented Apr 4, 2018

dotlambda commented Apr 4, 2018

dotlambda Apr 7, 2018

dotlambda Apr 7, 2018

dotlambda commented Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

dotlambda Apr 7, 2018

dotlambda Apr 7, 2018

dotlambda Apr 7, 2018

dotlambda Apr 7, 2018

dotlambda Apr 7, 2018

dotlambda Apr 7, 2018 •

edited

hangups: 0.4.4 #38255

hangups: 0.4.4 #38255

Conversation

aswan89 commented Mar 31, 2018

Motivation for this change

Things done

FRidh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Apr 3, 2018

GrahamcOfBorg commented Apr 3, 2018

GrahamcOfBorg commented Apr 3, 2018

dotlambda commented Apr 3, 2018

dotlambda commented Apr 4, 2018

GrahamcOfBorg commented Apr 4, 2018

GrahamcOfBorg commented Apr 4, 2018

dotlambda commented Apr 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda Apr 7, 2018 • edited

Choose a reason for hiding this comment

dotlambda Apr 7, 2018 •

edited