Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos testing: significantly reduce deps needed for OCR tests #38181

Merged
merged 1 commit into from Mar 31, 2018
Merged

nixos testing: significantly reduce deps needed for OCR tests #38181

merged 1 commit into from Mar 31, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 31, 2018

Instead of imagemagick built with many libraries
(notably librsvg which these days requires rust)
use imagemagick_light with support for libtiff added.

Smaller closure means fewer rebuilds/retests,
smaller VM sizes, and fewer dependencies
before being able to leverage OCR features
in the NixOS tests.

Mostly, no reason for rust updates to
cause all tests to be rerun,
but the other benefits are nice too :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
nixos testing: significantly reduce deps needed for OCR tests
ddd10e0 
Instead of imagemagick built with many libraries
(notably librsvg which these days requires rust)
use imagemagick_light with support for libtiff added.
@dtzWill dtzWill requested a review from aszlig March 31, 2018 05:38
@dtzWill
Copy link
Member Author

dtzWill commented Mar 31, 2018

@GrahamcOfBorg test slim sddm

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.slim, tests.sddm

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 22.98s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/0q7vi2a932sqz3pp1zrh60fdlgz1h6lj-vm-test-run-slim

@dtzWill dtzWill merged commit a5358e3 into NixOS:staging Mar 31, 2018
@dtzWill dtzWill deleted the feature/lighter-imagemagick-for-NixOS-tests branch March 31, 2018 08:45
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.slim, tests.sddm

Partial log (click to expand)

cannot build derivation '/nix/store/z2sp0rl96y75zgmcw636z948wrm4n8xp-unit-display-manager.service.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/h65fg6971p82wpwn4arqdx96zms7m72l-system-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/87m7swmvpkvisj7xy6sdwa02r9p2bydd-etc.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/5rdvzxjdm2z9x51nvsi8l9hr9alyri2a-nixos-system-machine-18.09.git.ddd10e0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/pgl2x2wzblc3qbq0xcqmw7r0vm93nk21-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/k8xc9jpyfpv7i1mdax182rgasgkl3im9-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/hgq31g90gcqdsgg53mpp8kn9g96dir1w-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/rg5pgyl4cn62jdl30cmws32ims33gmal-nixos-test-driver-slim.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kqf3djv1dlvsf596zgffhww31i9jfkbb-vm-test-run-slim.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/kqf3djv1dlvsf596zgffhww31i9jfkbb-vm-test-run-slim.drv' failed

@dtzWill dtzWill mentioned this pull request Apr 19, 2018
Merged
8 tasks
@c0bw3b c0bw3b added the 6.topic: testing Tooling for automated testing of packages and modules label Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig aszlig approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @aszlig @c0bw3b