Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major update of various JetBrains IDEs #38229

Merged
merged 8 commits into from Apr 8, 2018
Merged

Major update of various JetBrains IDEs #38229

merged 8 commits into from Apr 8, 2018

Conversation

matklad
Copy link
Member

@matklad matklad commented Mar 31, 2018

Motivation for this change

Routine update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (only checked idea community)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matklad matklad requested a review from edwtjo as a code owner March 31, 2018 14:41
@infinisil
Copy link
Member

@GrahamcOfBorg build jetbrains.clion jetbrains.goland jetbrains.idea-community jetbrains.idea-ultimate jetbrains.phpstorm jetbrains.pycharm-community jetbrains.pycharm-professional jetbrains.webstorm

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: jetbrains.clion, jetbrains.goland, jetbrains.idea-community, jetbrains.idea-ultimate, jetbrains.phpstorm, jetbrains.pycharm-community, jetbrains.pycharm-professional, jetbrains.webstorm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jetbrains.idea-community, jetbrains.pycharm-community

The following builds were skipped because they don't evaluate on x86_64-linux: jetbrains.clion, jetbrains.goland, jetbrains.idea-ultimate, jetbrains.phpstorm, jetbrains.pycharm-professional, jetbrains.webstorm

Partial log (click to expand)

shrinking /nix/store/z7k3i7pwmdx3zl66zjkbffmrfph2bf0q-idea-community-2018.1/idea-community-2018.1/jre64/bin/rmid
shrinking /nix/store/z7k3i7pwmdx3zl66zjkbffmrfph2bf0q-idea-community-2018.1/idea-community-2018.1/jre64/bin/rmiregistry
shrinking /nix/store/z7k3i7pwmdx3zl66zjkbffmrfph2bf0q-idea-community-2018.1/idea-community-2018.1/jre64/bin/servertool
shrinking /nix/store/z7k3i7pwmdx3zl66zjkbffmrfph2bf0q-idea-community-2018.1/idea-community-2018.1/jre64/bin/tnameserv
shrinking /nix/store/z7k3i7pwmdx3zl66zjkbffmrfph2bf0q-idea-community-2018.1/idea-community-2018.1/jre64/bin/unpack200
shrinking /nix/store/z7k3i7pwmdx3zl66zjkbffmrfph2bf0q-idea-community-2018.1/libexec/idea-community-2018.1/fsnotifier
shrinking /nix/store/z7k3i7pwmdx3zl66zjkbffmrfph2bf0q-idea-community-2018.1/libexec/idea-community-2018.1/fsnotifier-arm
shrinking /nix/store/z7k3i7pwmdx3zl66zjkbffmrfph2bf0q-idea-community-2018.1/libexec/idea-community-2018.1/fsnotifier64
/nix/store/z7k3i7pwmdx3zl66zjkbffmrfph2bf0q-idea-community-2018.1
/nix/store/w6lvsyz95b0ps3s0jrdxk10l6p7hmxhg-pycharm-community-2018.1

@matklad
Copy link
Member Author

matklad commented Apr 1, 2018

Verified that CLion and its bundled debuggers work as well!

@matklad
Copy link
Member Author

matklad commented Apr 6, 2018

cc @Mic92 because you've merged a couple of other jetbrains updates of mine :-)

@Mic92
Copy link
Member

Mic92 commented Apr 8, 2018

Goland fails to build for me.

@Mic92
Copy link
Member

Mic92 commented Apr 8, 2018 

$ nix-shell -p goland
...
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/lib/jexec
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/rmid
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/keytool
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/unpack200
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/orbd
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/policytool
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/jjs
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/rmiregistry
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/servertool
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/java
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/tnameserv
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/jre64/bin/pack200
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/lib/libpty/linux/x86/libpty.so
shrinking /nix/store/d8a22p9a91ml2xaizjnfah48afg3f7pw-goland-2018.1/goland-2018.1/lib/libpty/linux/x86_64/libpty.so
missing filename
builder for '/nix/store/d1w1x2i25zdivjbbcjcb0i603qmxxx9w-goland-2018.1.drv' failed with exit code 1
error: build of '/nix/store/d1w1x2i25zdivjbbcjcb0i603qmxxx9w-goland-2018.1.drv' failed

@matklad
Copy link
Member Author

matklad commented Apr 8, 2018

Thanks @Mic92! Updated the postFixUp!

@Mic92 Mic92 merged commit 610e385 into NixOS:master Apr 8, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 8, 2018

backported to 18.03

@infinisil
Copy link
Member

Why is this major update backported? Aren't releases only supposed to get bug and security fixes?

@Mic92
Copy link
Member

Mic92 commented Apr 8, 2018

Jetbrains delete old releases and nixos does not cache old tarballs because of the license

@infinisil
Copy link
Member

Oh I see :/

@matklad matklad deleted the update-jetbrains branch April 8, 2018 11:50
@matklad
Copy link
Member Author

matklad commented Apr 8, 2018

@infinisil also, given that JetBrains makes major releases somewhat more often than NixOS (three times per year), it may make sense to do backports to current stable to make these latest versions actually usable on nixos without a hassle. Using

@matklad
Copy link
Member Author

matklad commented Apr 8, 2018

... using something like overlays to get latest IntelliJ idea on stable NixOS is not fun (I've tried it, and eventually decided that it's just easier for me personally to send a PR to NixOS once in a while :-) ). Using older IntelliJ is not fun either, because the ides themselves get a ton of updates in major versions, and because authors of third-party plugins often support only the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matklad @infinisil @GrahamcOfBorg @Mic92