Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

click: init at 0.3.1 #38225

Merged
merged 1 commit into from Apr 9, 2018
Merged

click: init at 0.3.1 #38225

merged 1 commit into from Apr 9, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Mar 31, 2018 •
edited

Motivation for this change

Add click.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

nlewo
nlewo requested changes Apr 1, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -9570,7 +9570,7 @@ with pkgs;
libantlr3c = callPackage ../development/libraries/libantlr3c {};

libaom = callPackage ../development/libraries/libaom { };

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this diff?

pkgs/applications/networking/cluster/click/default.nix Outdated
buildInputs = stdenv.lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ];

meta = with stdenv.lib; {
description = "The \"Command Line Interactive Controller for Kubernetes\"";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non blocking) you could use """ instead of escaping "

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that should be '' (two single quotes). (The triple quotes thing is Python.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, exactly, sorry:)

@nlewo
Copy link
Member

nlewo commented Apr 1, 2018

@mbode we generally don't put the commit id in the package name and the manual don't talk about this.
It would be really nice to ask for an upsteam release... otherwise, do you really need to add the commit id in the name?

@mbode mbode force-pushed the click_0_3_1 branch 2 times, most recently from a297e3b to f228c62 Compare April 2, 2018 18:57
@mbode
Copy link
Contributor Author

mbode commented Apr 2, 2018

@nlewo I have removed the commit id. The next version is going to be released properly according to databricks/click#34.

@nlewo
Copy link
Member

nlewo commented Apr 3, 2018 •
edited

@mbode ok, thanks!
@GrahamcOfBorg build click

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: click

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/build'
cp: -r not specified; omitting directory 'target/release/.fingerprint'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3r0b27l87fwl1z53brv2645vgl2hpysb-click-0.3.1
shrinking /nix/store/3r0b27l87fwl1z53brv2645vgl2hpysb-click-0.3.1/bin/click
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3r0b27l87fwl1z53brv2645vgl2hpysb-click-0.3.1/bin
patching script interpreter paths in /nix/store/3r0b27l87fwl1z53brv2645vgl2hpysb-click-0.3.1
checking for references to /build in /nix/store/3r0b27l87fwl1z53brv2645vgl2hpysb-click-0.3.1...
/nix/store/3r0b27l87fwl1z53brv2645vgl2hpysb-click-0.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: click

Partial log (click to expand)

these derivations will be built:
  /nix/store/asam38yl73m0cqhnv1z4mb4g92ysdpkl-click-0.3.1-vendor.drv
  /nix/store/jqlxasa92a023qjkssddcb4ph44pbrxg-click-0.3.1.drv
waiting for locks or build slots...
/nix/store/3r0b27l87fwl1z53brv2645vgl2hpysb-click-0.3.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: click

Partial log (click to expand)

cannot build derivation '/nix/store/jd5sxbq7sa5x6xzrchkypp2q87drplry-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/9qa50x766wwvaxxvd10nk1p4xviidfi2-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/qvjhfy22hgqk2lg6r3mk5ym84vj7s9h8-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/142y4gkx972zvpp0gqxhcwq9rqf7ad21-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/i55qyd3liqs7yqq0fhr94y6vk02r4jib-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/j2qmwqmgifin75d0z8wdl1968jr1s9h5-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/w7y9d8gq23lfxb4qd2yfkhc8k0z54hma-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/f9bhmhsydhzffx5dv1p31j5a30j355si-click-0.3.1-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bhnh035zayvknjka36wrqcvciyls1i5s-click-0.3.1.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/bhnh035zayvknjka36wrqcvciyls1i5s-click-0.3.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: click

Partial log (click to expand)

cannot build derivation '/nix/store/jd5sxbq7sa5x6xzrchkypp2q87drplry-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/9qa50x766wwvaxxvd10nk1p4xviidfi2-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/qvjhfy22hgqk2lg6r3mk5ym84vj7s9h8-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/142y4gkx972zvpp0gqxhcwq9rqf7ad21-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/i55qyd3liqs7yqq0fhr94y6vk02r4jib-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/j2qmwqmgifin75d0z8wdl1968jr1s9h5-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/w7y9d8gq23lfxb4qd2yfkhc8k0z54hma-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/f9bhmhsydhzffx5dv1p31j5a30j355si-click-0.3.1-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bhnh035zayvknjka36wrqcvciyls1i5s-click-0.3.1.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/bhnh035zayvknjka36wrqcvciyls1i5s-click-0.3.1.drv' failed

@nlewo
Copy link
Member

nlewo commented Apr 3, 2018

@mbode could you either fix the build for aarch64 or restrict it to x86 and darwin?

@matthewbauer matthewbauer merged commit 1d951cf into NixOS:master Apr 9, 2018
@mbode mbode deleted the click_0_3_1 branch April 12, 2018 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor left review comments

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mbode @nlewo @GrahamcOfBorg @bjornfor @matthewbauer