Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.imbalanced-learn: 0.3.2 -> 0.3.3, fix build #38245

Merged
merged 1 commit into from Apr 1, 2018
Merged

pythonPackages.imbalanced-learn: 0.3.2 -> 0.3.3, fix build #38245

merged 1 commit into from Apr 1, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 31, 2018

Motivation for this change

ZHF #36453 . Build (tests) failed.

minor bump, fix tests, move to development/python-modules

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji xeji requested a review from FRidh as a code owner March 31, 2018 17:55
@xeji
Copy link
Contributor Author

xeji commented Mar 31, 2018

@GrahamcOfBorg build python27Packages.imbalanced-learn python36Packages.imbalanced-learn

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.imbalanced-learn, python36Packages.imbalanced-learn

Partial log (click to expand)


=============================== warnings summary ===============================
doc/under_sampling.rst::under_sampling.rst
  /nix/store/kahw886ikcv543r4h4xrdg6lz2mcbpx3-python2.7-imbalanced-learn-0.3.3/lib/python2.7/site-packages/imblearn/under_sampling/prototype_selection/one_sided_selection.py:197: DeprecationWarning: in the future out of bounds indices will raise an error instead of being ignored by `numpy.delete`.
    idx_maj_extracted = np.delete(idx_maj, idx_maj_sample, axis=0)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
===================== 5 passed, 1 warnings in 5.47 seconds =====================
/nix/store/kahw886ikcv543r4h4xrdg6lz2mcbpx3-python2.7-imbalanced-learn-0.3.3
/nix/store/4lr79rcx4vnpv1fkwglm8d1sdzcy69f1-python3.6-imbalanced-learn-0.3.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python27Packages.imbalanced-learn, python36Packages.imbalanced-learn

Partial log (click to expand)

........................................................................ [ 67%]
................................................................         [ 68%]
../../nix/store/v67mrh16nc6169icwhivb2b98l742lqc-python2.7-pandas-0.22.0/lib/python2.7/site-packages/pandas/tests/io/formats/test_printing.py . [ 68%]
......sssss                                                              [ 68%]
../../nix/store/v67mrh16nc6169icwhivb2b98l742lqc-python2.7-pandas-0.22.0/lib/python2.7/site-packages/pandas/tests/io/formats/test_style.py . [ 68%]
building of '/nix/store/qaan05bxk57cz3gcqn1ykld9v4884p22-python2.7-pandas-0.22.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/gm853kvwibpnc5l24pgfypdkcqvzxsxv-python2.7-imbalanced-learn-0.3.3.drv': 2 dependencies couldn't be built
building of '/nix/store/qs99hvyac7xkv7fzazgqwlhxkvkc0rc1-python3.6-pandas-0.22.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/mxgbrhmla632fjrzn525b9m7qi0wdpqh-python3.6-imbalanced-learn-0.3.3.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/gm853kvwibpnc5l24pgfypdkcqvzxsxv-python2.7-imbalanced-learn-0.3.3.drv', '/nix/store/mxgbrhmla632fjrzn525b9m7qi0wdpqh-python3.6-imbalanced-learn-0.3.3.drv' failed

dotlambda
dotlambda reviewed Mar 31, 2018
View reviewed changes
pkgs/development/python-modules/imbalanced-learn/default.nix Outdated
{ stdenv, buildPythonPackage, fetchPypi, scikitlearn, pandas, nose, pytest }:

buildPythonPackage rec {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary whitespace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

pkgs/development/python-modules/imbalanced-learn/default.nix Outdated
'';

propagatedBuildInputs = [ scikitlearn ];
buildInputs = [ pandas ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this is an optional dependency? Why is it in buildInputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the source code, it is optional and only used in a test utility. Without it, a number of tests are skipped. Moved to checkInputs.

pkgs/development/python-modules/imbalanced-learn/default.nix Outdated
};

preConfigure = ''
export HOME=$PWD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed for anything other than the tests? If not, it belongs into checkPhase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests only. moved to checkPhase.

@xeji
pythonPackages.imbalanced-learn: 0.3.2 -> 0.3.3, fix build
6b2bc4b 
minor bump, fix tests, move to development/python-modules
@xeji
Copy link
Contributor Author

xeji commented Apr 1, 2018

@GrahamcOfBorg build python27Packages.imbalanced-learn python36Packages.imbalanced-learn

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.imbalanced-learn, python36Packages.imbalanced-learn

Partial log (click to expand)


doc/under_sampling.rst::under_sampling.rst

  /nix/store/ifvjl87nlarvhrmn5s2qdh3jq0s9z7x5-python3.6-imbalanced-learn-0.3.3/lib/python3.6/site-packages/imblearn/under_sampling/prototype_selection/one_sided_selection.py:197: DeprecationWarning: in the future out of bounds indices will raise an error instead of being ignored by `numpy.delete`.
    idx_maj_extracted = np.delete(idx_maj, idx_maj_sample, axis=0)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
===================== 5 passed, 1 warnings in 7.05 seconds =====================
/nix/store/4id6w8iblacbl9cg6w8fbc3mw22ghzwh-python2.7-imbalanced-learn-0.3.3
/nix/store/ifvjl87nlarvhrmn5s2qdh3jq0s9z7x5-python3.6-imbalanced-learn-0.3.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python27Packages.imbalanced-learn, python36Packages.imbalanced-learn

Partial log (click to expand)

../../nix/store/ysa7ndiz6mhzh2cpa8dj65myjp7332br-python3.6-pandas-0.22.0/lib/python3.6/site-packages/pandas/tests/io/test_stata.py . [ 65%]
........................................................................ [ 65%]
........................................................................ [ 66%]
........................................................................ [ 66%]
........................................................................ [ 66%]
building of '/nix/store/qaan05bxk57cz3gcqn1ykld9v4884p22-python2.7-pandas-0.22.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/sfjf2mv5chrnwkq55xlw3znqsggn1zr4-python2.7-imbalanced-learn-0.3.3.drv': 2 dependencies couldn't be built
building of '/nix/store/qs99hvyac7xkv7fzazgqwlhxkvkc0rc1-python3.6-pandas-0.22.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/a5f4imgvxh4z7vqklyihqvs4ymix4n34-python3.6-imbalanced-learn-0.3.3.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/a5f4imgvxh4z7vqklyihqvs4ymix4n34-python3.6-imbalanced-learn-0.3.3.drv', '/nix/store/sfjf2mv5chrnwkq55xlw3znqsggn1zr4-python2.7-imbalanced-learn-0.3.3.drv' failed

@dotlambda dotlambda merged commit dd7900a into NixOS:master Apr 1, 2018
@dotlambda
Copy link
Member

Backported in da36dff.

@xeji xeji deleted the p/imbalanced-learn branch April 1, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @dotlambda