Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magic-wormhole: make available as an application #38220

Merged
merged 1 commit into from Apr 1, 2018
Merged

magic-wormhole: make available as an application #38220

merged 1 commit into from Apr 1, 2018

Conversation

jluttine
Copy link
Member

Motivation for this change

Currently, magic-wormhole is a Python package. However, I think it should be an application because I don't see it used as a library but as an application. Perhaps the maintainer wants to comment @asymmetric ?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner March 31, 2018 13:12
@jluttine
Copy link
Member Author

Or is this just something that doesn't really matter? I found it confusing that when I wanted to try magic wormhole, it wasn't available with nix-shell -p magic-wormhole but I needed to first realize that it's actually a Python package so it's available as nix-shell -p pythonPackages.magic-wormhole.

@jluttine jluttine force-pushed the magic-wormhole-as-application branch from 8aaf6ae to 821b03d Compare March 31, 2018 13:16
@dotlambda
Copy link
Member

It seems to also provide a library: https://magic-wormhole.readthedocs.io/en/latest/welcome.html#library.
However, you could add a global alias using toPythonApplication.

@jluttine jluttine force-pushed the magic-wormhole-as-application branch from 821b03d to 7f291f8 Compare April 1, 2018 06:01
@jluttine
Copy link
Member Author

jluttine commented Apr 1, 2018

@dotlambda Ok, thanks! This was then a very simple change, thanks to that toPythonApplication.

@jluttine jluttine changed the title magic-wormhole: convert package to application magic-wormhole: make available as an application Apr 1, 2018
@dotlambda
Copy link
Member

@GrahamcOfBorg build magic-wormhole

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: magic-wormhole

Partial log (click to expand)

copying path '/nix/store/kfwhw1kvv3m7md4z6lwphnq49c4zifj2-python3.6-pynacl-1.2.1' from 'https://cache.nixos.org'...
copying path '/nix/store/2gfms077ai53l5ncwlzgddiqild1n3lp-python3.6-Twisted-17.9.0' from 'https://cache.nixos.org'...
copying path '/nix/store/5vk597wyb4rwb9428jvfx7n4893rzdfn-python3.6-cryptography-2.1.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/izzw6w05j7r5a5wp3yikmfxacz51van3-python3.6-pyOpenSSL-17.5.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/vd48jiy63ij2vf94mf5mm5vfysm1sxsd-python3.6-service_identity-17.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/6l3m10i1av3ni5d30hj0gmfwfmiidm2s-python3.6-txaio-2.8.2' from 'https://cache.nixos.org'...
copying path '/nix/store/rlrkwl5rk4c7dhlbji4cfvw3yk0p7pvq-python3.6-txtorcon-0.20.0' from 'https://cache.nixos.org'...
copying path '/nix/store/pqk749agw5abphzkc5zznjjri3ha3r7k-python3.6-autobahn-17.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/bbfw5p23bs30aw72r5fqpm4p0cfn6rc9-python3.6-magic-wormhole-0.10.5' from 'https://cache.nixos.org'...
/nix/store/bbfw5p23bs30aw72r5fqpm4p0cfn6rc9-python3.6-magic-wormhole-0.10.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: magic-wormhole

Partial log (click to expand)

--:--:-
-     0

  5  219k    5 11584    0     0  11584      0  0:00:19 --:--:--  0:00:19 21061

100  219k  100  219
k    0     0   219k      0  0:00:01  0:00:01
 --:--:--
 198k


/nix/store/a7vwlbjl5qh8ymmsvn70ipmacq9jfsv0-python3.6-magic-wormhole-0.10.5

@dotlambda dotlambda merged commit 7b36145 into NixOS:master Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jluttine @dotlambda @GrahamcOfBorg @FRidh