metrics: fixup sed expr to work with Nix 2 #36896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzWill
force-pushed
the
fix/metrics-sed
branch
from
c66c462
to
5eb07e2
Compare
|
Rebased onto non-broken master :). Let's try this again. |
dezgeg
reviewed
Mar 13, 2018
| @@ -35,7 +35,7 @@ runCommand "nixpkgs-metrics" | |||
| [[ -n $x ]] || exit 1 | |||
| echo "$name.allocations $x B" >> $out/nix-support/hydra-metrics | |||
|
|
|||
| x=$(sed -e 's/.*values allocated: \([0-9]\+\) .*/\1/ ; t ; d' stats) | |||
| x=$(sed -e 's/.*values allocated bytes: \([0-9]\+\).*/\1/ ; t ; d' stats) | |||
There was a problem hiding this comment.
I think this was supposed to be values allocated count, not bytes: https://hydra.nixos.org/job/nixpkgs/trunk/metrics#tabs-charts
There was a problem hiding this comment.
Eep, yes. Sorry about that.
Review was for approval of "requiring" Nix 2 for this (thanks!), will fix shortly.
etu
pushed a commit
to etu/nixpkgs
that referenced
this pull request
Mar 13, 2018
fpletz
pushed a commit
that referenced
this pull request
Mar 13, 2018
#36896 (comment) (cherry picked from commit 29d4647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently metrics job fails, which is blocking the unstable channel.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)EDIT: fixed zed in 708e3fb
Currently still fails on one of the items due to some problem in node-env.nix missing 'libtool',
which is mentioned in recent commits so hopefully will be fixed soon, and maybe has already :).
Here's the error, FWIW: