Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mention symlinkJoin in multiple-outputs section #36886

Merged
merged 1 commit into from Mar 31, 2019
Merged

doc: mention symlinkJoin in multiple-outputs section #36886

merged 1 commit into from Mar 31, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 12, 2018

Motivation for this change

Provide an additional exposure for symlinkJoin function by mentioning it in the documentation.

Fixes #36883

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl veprbl mentioned this pull request Mar 12, 2018
Closed
alyssais
alyssais reviewed Dec 7, 2018
View reviewed changes
doc/multiple-output.xml Outdated Show resolved Hide resolved
@strager
Copy link
Contributor

strager commented Mar 31, 2019

This documentation would have saved me a handful of minutes! Can we merge this PR?

@veprbl veprbl merged commit c6a8b56 into NixOS:master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @strager @alyssais @GrahamcOfBorg