Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: Prepare for #34444 #36885

Merged
merged 8 commits into from Mar 12, 2018
Merged

treewide: Prepare for #34444 #36885

merged 8 commits into from Mar 12, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

#34444 changes the meta.platform interface slightly. This PR fixes/improves a few misc packages so that that one doesn't change anything.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nethack

The following builds were skipped because they don't evaluate on x86_64-darwin: ceph, dvdisaster, pharo, pond, robo3t

Partial log (click to expand)

/nix/store/z1v51i8zviwij91nfgrn86103nbs8ik2-nethack-3.6.0

@Ericson2314 Ericson2314 merged commit 62ca231 into NixOS:master Mar 12, 2018
@Ericson2314 Ericson2314 deleted the meta-host-prepare branch March 12, 2018 23:06
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ceph, dvdisaster, nethack, pharo, pond, robo3t

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/wxgl2a8z7p62d7bb9jl0ms67sjr3i154-pharo/bin 
patching script interpreter paths in /nix/store/wxgl2a8z7p62d7bb9jl0ms67sjr3i154-pharo
/nix/store/wxgl2a8z7p62d7bb9jl0ms67sjr3i154-pharo/bin/pharo: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-pharo.drv-0 in /nix/store/wxgl2a8z7p62d7bb9jl0ms67sjr3i154-pharo...
/nix/store/rr6qrrkiplwgaa996mwb50kayvnrq82w-ceph-12.2.2-dev
/nix/store/m8zp5j6k9528675rq6mxg7lpks3q8qhw-dvdisaster-0.79.5
/nix/store/v237i597wfqd7ga9696202xzdrzyrgrs-nethack-3.6.0
/nix/store/wxgl2a8z7p62d7bb9jl0ms67sjr3i154-pharo
/nix/store/d5788dwp38zmlb3i2v5551ihc20wgmy6-pond-20150830-bce6e0d-bin
/nix/store/6p5ihq04y5j86lzrgz9smkvwkphmxxy3-robo3t-1.1.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ceph, dvdisaster, nethack, pond

The following builds were skipped because they don't evaluate on aarch64-linux: pharo, robo3t

Partial log (click to expand)

 ^
./util/coding.h: In function 'uint64_t rocksdb::DecodeFixed64(const char*)':
./util/coding.h:114:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make: *** [Makefile:1835: db/write_batch.o] Error 1
make: *** [Makefile:1835: db/db_impl_open.o] Error 1
builder for '/nix/store/qqphgaxm3gc4lks6bkgjkf6p8gdlzmkw-rocksdb-5.10.3.drv' failed with exit code 2
cannot build derivation '/nix/store/jxwh06fj57fk9g1xy32b2882q5i1mwib-ceph-12.2.2.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/jxwh06fj57fk9g1xy32b2882q5i1mwib-ceph-12.2.2.drv', '/nix/store/sxlr85fvkvir3jkx6j1ycnrh8d75ga2a-pond-20150830-bce6e0d.drv' failed

nckx
nckx reviewed Mar 12, 2018
View reviewed changes
pkgs/applications/misc/robo3t/default.nix
@@ -70,7 +70,7 @@ stdenv.mkDerivation rec {
meta = {
homepage = https://robomongo.org/;
description = "Query GUI for mongodb";
platforms = stdenv.lib.intersectLists stdenv.lib.platforms.linux stdenv.lib.platforms.x86_64;
platforms = [ "x86_64-linux" ];
Copy link
Member

@nckx nckx Mar 12, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the only intersection, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nckx nckx nckx left review comments

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@wkennington wkennington Awaiting requested review from wkennington

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @GrahamcOfBorg @nckx