Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p4v: init at 2017.3.1601999 #36884

Merged
merged 3 commits into from Apr 9, 2018
Merged

p4v: init at 2017.3.1601999 #36884

merged 3 commits into from Apr 9, 2018

Conversation

nioncode
Copy link
Member

@nioncode nioncode commented Mar 12, 2018 •
edited

Motivation for this change

Package the Perforce Visual Client for nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 18, 2018

@GrahamcOfBorg build p4v

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: p4v

No log is available.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux

The following builds were skipped because they don't evaluate on aarch64-linux: p4v

No log is available.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux

The following builds were skipped because they don't evaluate on x86_64-linux: p4v

No log is available.

@grahamc
Copy link
Member

grahamc commented Mar 18, 2018 

grahamc@Morbo> HOME=/homeless-shelter NIX_PATH=nixpkgs=$(pwd) nix-instantiate ./default.nix -A p4v --option restrict-eval true --option build-timeout 1800 --argstr system x86_64-darwin --show-trace                   
error: while evaluating the attribute ‘handled’ at /home/grahamc/projects/nixpkgs/pkgs/stdenv/generic/check-meta.nix:206:7:
while evaluating ‘handleEvalIssue’ at /home/grahamc/projects/nixpkgs/pkgs/stdenv/generic/check-meta.nix:124:28, called from /home/grahamc/projects/nixpkgs/pkgs/stdenv/generic/check-meta.nix:207:14:
Package ‘p4v-2017.3.1601999’ in /home/grahamc/projects/nixpkgs/pkgs/applications/version-management/p4v/default.nix:42 has an unfree license (‘unfreeRedistributable’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@grahamc
Copy link
Member

grahamc commented Mar 18, 2018 •
edited

@GrahamcOfBorg build p4v

I'm sorry to spam the PR, it is very useful for some testing...

@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Mar 18, 2018
@matthewbauer matthewbauer merged commit a7341d7 into NixOS:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nioncode @jtojnar @GrahamcOfBorg @grahamc @matthewbauer