Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init Limesuite, SoapySDR #37020

Closed
wants to merge 3 commits into from
Closed

init Limesuite, SoapySDR #37020

wants to merge 3 commits into from

Conversation

roosemberth
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add name to maintainers' list
30a8773 
Signed-off-by: Roosembert Palacios <roosembert.palacios@epfl.ch>
@roosemberth roosemberth changed the title Limesuite init Limesuite, SoapySDR Mar 14, 2018
Roosembert Palacios added 2 commits March 14, 2018 21:24
soapysdr: init at 0.6.1
0d03fe9 
Signed-off-by: Roosembert Palacios <roosembert.palacios@epfl.ch>
limesuite: init at 17.12.0
c26a464 
Signed-off-by: Roosembert Palacios <roosembert.palacios@epfl.ch>
@ryantm
Copy link
Member

ryantm commented Mar 15, 2018

@GrahamcOfBorg build soapysdr limesuite

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: soapysdr, limesuite

Partial log (click to expand)

shrinking /nix/store/06njxrs249qpmbjhpqqc27xiwy5krqj5-LimeSuite-17.12.0/bin/LimeSuiteGUI
shrinking /nix/store/06njxrs249qpmbjhpqqc27xiwy5krqj5-LimeSuite-17.12.0/bin/LimeUtil
shrinking /nix/store/06njxrs249qpmbjhpqqc27xiwy5krqj5-LimeSuite-17.12.0/lib/libLimeSuite.so.17.12.0
shrinking /nix/store/06njxrs249qpmbjhpqqc27xiwy5krqj5-LimeSuite-17.12.0/lib/SoapySDR/modules0.6/libLMS7Support.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/06njxrs249qpmbjhpqqc27xiwy5krqj5-LimeSuite-17.12.0/lib  /nix/store/06njxrs249qpmbjhpqqc27xiwy5krqj5-LimeSuite-17.12.0/bin 
patching script interpreter paths in /nix/store/06njxrs249qpmbjhpqqc27xiwy5krqj5-LimeSuite-17.12.0
/nix/store/06njxrs249qpmbjhpqqc27xiwy5krqj5-LimeSuite-17.12.0/share/Lime/Desktop/install: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/06njxrs249qpmbjhpqqc27xiwy5krqj5-LimeSuite-17.12.0/share/Lime/Desktop/uninstall: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-LimeSuite-17.12.0.drv-0 in /nix/store/06njxrs249qpmbjhpqqc27xiwy5krqj5-LimeSuite-17.12.0...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: soapysdr, limesuite

Partial log (click to expand)

shrinking /nix/store/nh05p4dgc1sbrf7v02m8y2plkq4z79zy-LimeSuite-17.12.0/lib/SoapySDR/modules0.6/libLMS7Support.so
shrinking /nix/store/nh05p4dgc1sbrf7v02m8y2plkq4z79zy-LimeSuite-17.12.0/lib/libLimeSuite.so.17.12.0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nh05p4dgc1sbrf7v02m8y2plkq4z79zy-LimeSuite-17.12.0/lib  /nix/store/nh05p4dgc1sbrf7v02m8y2plkq4z79zy-LimeSuite-17.12.0/bin
patching script interpreter paths in /nix/store/nh05p4dgc1sbrf7v02m8y2plkq4z79zy-LimeSuite-17.12.0
/nix/store/nh05p4dgc1sbrf7v02m8y2plkq4z79zy-LimeSuite-17.12.0/share/Lime/Desktop/uninstall: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/nh05p4dgc1sbrf7v02m8y2plkq4z79zy-LimeSuite-17.12.0/share/Lime/Desktop/install: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/nh05p4dgc1sbrf7v02m8y2plkq4z79zy-LimeSuite-17.12.0...
/nix/store/jr84qgggfgar257mm6kziazdjwzrwpn7-SoapySDR-0.6.1
/nix/store/nh05p4dgc1sbrf7v02m8y2plkq4z79zy-LimeSuite-17.12.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: soapysdr, limesuite

No log is available.

markuskowa
markuskowa reviewed Mar 15, 2018
View reviewed changes
pkgs/applications/misc/limesuite/default.nix

buildInputs = [ libusb cmake wxGTK30 mesa libX11 soapysdr sqlite doxygen gnuplot ];

configurePhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defining a configure phase is not necessary here. You can use cmakeFlags = [ "-DENABLE_STREAM_UNITE=ON" ] instead.

pkgs/applications/misc/limesuite/default.nix
version = "17.12.0";
name = "LimeSuite-${version}";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fetchFromGitHub is the preferred method:
src = fetchFromGitHub {
owner = "myriadrf";
repo = "LimeSuite";
rev = "v${version}";
sha256 = "1rd79xxnwr62fmy2vq895jyiqnz6lm4p8bl09adjqqm4y5npryf9";
};

pkgs/applications/misc/soapysdr/default.nix
"-DPYTHON3_EXECUTABLE=${python3}/bin/python"
];

configurePhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Defining cmakeFlags should be enough.

@markuskowa
Copy link
Member

markuskowa commented Mar 15, 2018 •
edited

How do you keep track of the SoapySDR plugins? Every application that wants to use the soapysdr backend needs to have (i) an environment variable set pointing to all plugin derivations or (ii) have all plugins need to be at a soapysdr compiled-in path.

@markuskowa markuskowa mentioned this pull request Apr 25, 2018
Merged
8 tasks
@roosemberth roosemberth deleted the limesuite branch April 29, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roosemberth @ryantm @GrahamcOfBorg @markuskowa