Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profanity: fix build on darwin #36992

Merged
merged 1 commit into from Mar 21, 2018
Merged

profanity: fix build on darwin #36992

merged 1 commit into from Mar 21, 2018

Conversation

hschaeidt
Copy link
Contributor

@hschaeidt hschaeidt commented Mar 14, 2018 •
edited

Motivation for this change

18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@hschaeidt hschaeidt changed the title profanity: fix build on osx profanity: fix build on darwin Mar 14, 2018
@mpickering
Copy link
Contributor

Seems to have some unrelated changes from #36988 in?

@hschaeidt
Copy link
Contributor Author

yes, that's because the package from #36988 is a direct dependency for profanity. not sure if we need 2 pull requests or if both can be merged with this one?

@LnL7
Copy link
Member

LnL7 commented Mar 16, 2018

@GrahamcOfBorg build stabber profanity

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: stabber, profanity

Partial log (click to expand)

/nix/store/qy7p75dr4sg0frgx00y6hawcwqcjwkmx-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/qy7p75dr4sg0frgx00y6hawcwqcjwkmx-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/qy7p75dr4sg0frgx00y6hawcwqcjwkmx-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/qy7p75dr4sg0frgx00y6hawcwqcjwkmx-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/qy7p75dr4sg0frgx00y6hawcwqcjwkmx-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/qy7p75dr4sg0frgx00y6hawcwqcjwkmx-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/qy7p75dr4sg0frgx00y6hawcwqcjwkmx-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/qy7p75dr4sg0frgx00y6hawcwqcjwkmx-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/swhm5zsr7wbyp231v0w9dy56j8b5zpls-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4
/nix/store/qy7p75dr4sg0frgx00y6hawcwqcjwkmx-profanity-0.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: stabber, profanity

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/5ps5kzxy3x6l0nk4zfdfh02dhqmab5sa-profanity-0.5.1
shrinking /nix/store/5ps5kzxy3x6l0nk4zfdfh02dhqmab5sa-profanity-0.5.1/bin/profanity
shrinking /nix/store/5ps5kzxy3x6l0nk4zfdfh02dhqmab5sa-profanity-0.5.1/lib/libprofanity.so
gzipping man pages under /nix/store/5ps5kzxy3x6l0nk4zfdfh02dhqmab5sa-profanity-0.5.1/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5ps5kzxy3x6l0nk4zfdfh02dhqmab5sa-profanity-0.5.1/lib  /nix/store/5ps5kzxy3x6l0nk4zfdfh02dhqmab5sa-profanity-0.5.1/bin
patching script interpreter paths in /nix/store/5ps5kzxy3x6l0nk4zfdfh02dhqmab5sa-profanity-0.5.1
checking for references to /build in /nix/store/5ps5kzxy3x6l0nk4zfdfh02dhqmab5sa-profanity-0.5.1...
/nix/store/xk0vx3gzqvb3nrnfij1jal38wbikmc31-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4
/nix/store/5ps5kzxy3x6l0nk4zfdfh02dhqmab5sa-profanity-0.5.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: stabber, profanity

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/w4y6qp6racxhgyf6ca6fgiawayk72nyl-profanity-0.5.1
shrinking /nix/store/w4y6qp6racxhgyf6ca6fgiawayk72nyl-profanity-0.5.1/bin/profanity
shrinking /nix/store/w4y6qp6racxhgyf6ca6fgiawayk72nyl-profanity-0.5.1/lib/libprofanity.so
gzipping man pages under /nix/store/w4y6qp6racxhgyf6ca6fgiawayk72nyl-profanity-0.5.1/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/w4y6qp6racxhgyf6ca6fgiawayk72nyl-profanity-0.5.1/lib  /nix/store/w4y6qp6racxhgyf6ca6fgiawayk72nyl-profanity-0.5.1/bin
patching script interpreter paths in /nix/store/w4y6qp6racxhgyf6ca6fgiawayk72nyl-profanity-0.5.1
checking for references to /build in /nix/store/w4y6qp6racxhgyf6ca6fgiawayk72nyl-profanity-0.5.1...
/nix/store/nwpqz1jnjcxhwh9pb7scym9w0zgdy652-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4
/nix/store/w4y6qp6racxhgyf6ca6fgiawayk72nyl-profanity-0.5.1

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Mar 19, 2018
@hschaeidt
Copy link
Contributor Author

cc/ @devhell as main maintainer

@devhell
Copy link
Contributor

devhell commented Mar 21, 2018

👍 Thank you very much @hschaeidt :)

globin
globin approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@globin globin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks fine

pkgs/applications/networking/instant-messengers/profanity/default.nix Outdated

nativeBuildInputs = [ pkgconfig ];
enableParallelBuilding = true;

buildInputs = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoreconfHook and pkgconfig should be in nativeBuildInputs

@hschaeidt
Copy link
Contributor Author

i did the changes. additionally activated the check phase, as the package has a test suite

@globin
Copy link
Member

globin commented Mar 21, 2018

@GrahamcOfBorg build profanity

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: profanity

Partial log (click to expand)

/nix/store/6fg87h68rsl3zbhkadbv1dsnf2l4n5jr-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/6fg87h68rsl3zbhkadbv1dsnf2l4n5jr-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/6fg87h68rsl3zbhkadbv1dsnf2l4n5jr-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/6fg87h68rsl3zbhkadbv1dsnf2l4n5jr-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/6fg87h68rsl3zbhkadbv1dsnf2l4n5jr-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/6fg87h68rsl3zbhkadbv1dsnf2l4n5jr-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/6fg87h68rsl3zbhkadbv1dsnf2l4n5jr-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/6fg87h68rsl3zbhkadbv1dsnf2l4n5jr-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/6fg87h68rsl3zbhkadbv1dsnf2l4n5jr-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/6fg87h68rsl3zbhkadbv1dsnf2l4n5jr-profanity-0.5.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: profanity

Partial log (click to expand)

============================================================================
make[3]: *** [Makefile:3538: test-suite.log] Error 1
make[3]: Leaving directory '/build/source'
make[2]: *** [Makefile:3646: check-TESTS] Error 2
make[2]: Leaving directory '/build/source'
make[1]: *** [Makefile:3860: check-am] Error 2
make[1]: Leaving directory '/build/source'
make: *** [Makefile:3862: check] Error 2
builder for '/nix/store/b2hahhgpyvqnxy87rrncasx250ypdhjd-profanity-0.5.1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/b2hahhgpyvqnxy87rrncasx250ypdhjd-profanity-0.5.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: profanity

Partial log (click to expand)

============================================================================
make[3]: *** [Makefile:3538: test-suite.log] Error 1
make[3]: Leaving directory '/build/source'
make[2]: *** [Makefile:3646: check-TESTS] Error 2
make[2]: Leaving directory '/build/source'
make[1]: *** [Makefile:3860: check-am] Error 2
make[1]: Leaving directory '/build/source'
make: *** [Makefile:3862: check] Error 2
builder for '/nix/store/c01xsvv6xrj4ac97i32pajzgq00f7snb-profanity-0.5.1.drv' failed with exit code 2
error: build of '/nix/store/c01xsvv6xrj4ac97i32pajzgq00f7snb-profanity-0.5.1.drv' failed

@hschaeidt @globin
profanity: refactor build to build from source
c323beb 
* fix osx build
* fix undefined macros in configure.ac
* activate the check phase to run the test suite
@globin
Copy link
Member

globin commented Mar 21, 2018

@GrahamcOfBorg build profanity

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: profanity

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5snfy7gm2yznddzc05h0xhnl6svzkd78-profanity-0.5.1
shrinking /nix/store/5snfy7gm2yznddzc05h0xhnl6svzkd78-profanity-0.5.1/bin/profanity
shrinking /nix/store/5snfy7gm2yznddzc05h0xhnl6svzkd78-profanity-0.5.1/lib/libprofanity.so
gzipping man pages under /nix/store/5snfy7gm2yznddzc05h0xhnl6svzkd78-profanity-0.5.1/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5snfy7gm2yznddzc05h0xhnl6svzkd78-profanity-0.5.1/lib  /nix/store/5snfy7gm2yznddzc05h0xhnl6svzkd78-profanity-0.5.1/bin
patching script interpreter paths in /nix/store/5snfy7gm2yznddzc05h0xhnl6svzkd78-profanity-0.5.1
checking for references to /tmp/nix-build-profanity-0.5.1.drv-0 in /nix/store/5snfy7gm2yznddzc05h0xhnl6svzkd78-profanity-0.5.1...
/nix/store/5snfy7gm2yznddzc05h0xhnl6svzkd78-profanity-0.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: profanity

Partial log (click to expand)

/nix/store/zilixnjdq8893jhbwqy2q3xnsdadsj3z-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/zilixnjdq8893jhbwqy2q3xnsdadsj3z-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/zilixnjdq8893jhbwqy2q3xnsdadsj3z-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/zilixnjdq8893jhbwqy2q3xnsdadsj3z-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/zilixnjdq8893jhbwqy2q3xnsdadsj3z-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/zilixnjdq8893jhbwqy2q3xnsdadsj3z-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/zilixnjdq8893jhbwqy2q3xnsdadsj3z-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/zilixnjdq8893jhbwqy2q3xnsdadsj3z-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/zilixnjdq8893jhbwqy2q3xnsdadsj3z-profanity-0.5.1/lib/libprofanity.dylib: fixing dylib
/nix/store/zilixnjdq8893jhbwqy2q3xnsdadsj3z-profanity-0.5.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: profanity

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4lq7cfwkvwadznkxapfpxxs2yx8lwfcx-profanity-0.5.1
shrinking /nix/store/4lq7cfwkvwadznkxapfpxxs2yx8lwfcx-profanity-0.5.1/bin/profanity
shrinking /nix/store/4lq7cfwkvwadznkxapfpxxs2yx8lwfcx-profanity-0.5.1/lib/libprofanity.so
gzipping man pages under /nix/store/4lq7cfwkvwadznkxapfpxxs2yx8lwfcx-profanity-0.5.1/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4lq7cfwkvwadznkxapfpxxs2yx8lwfcx-profanity-0.5.1/lib  /nix/store/4lq7cfwkvwadznkxapfpxxs2yx8lwfcx-profanity-0.5.1/bin
patching script interpreter paths in /nix/store/4lq7cfwkvwadznkxapfpxxs2yx8lwfcx-profanity-0.5.1
checking for references to /build in /nix/store/4lq7cfwkvwadznkxapfpxxs2yx8lwfcx-profanity-0.5.1...
/nix/store/4lq7cfwkvwadznkxapfpxxs2yx8lwfcx-profanity-0.5.1

@globin globin merged commit 501b6d0 into NixOS:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin globin approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hschaeidt @mpickering @LnL7 @GrahamcOfBorg @devhell @globin