Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bar: init at version 1.11.1 #37035

Merged
merged 1 commit into from Mar 18, 2018
Merged

bar: init at version 1.11.1 #37035

merged 1 commit into from Mar 18, 2018

Conversation

rdnetto
Copy link
Contributor

@rdnetto rdnetto commented Mar 14, 2018

Motivation for this change

bar is a fairly common alternative to dd which provides a progress bar for transfers.

Things done
  • added bar
  • removed alias for lemonbar, as it was shadowing it. The name bar refers to the bar package on every distro I checked, so I think changing this is warranted to avoid confusion.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rdnetto
bar: init at version 1.11.1
0bba975 
Removed lemonbar alias to avoid collision.
@ryantm
Copy link
Member

ryantm commented Mar 15, 2018

It looks like this should be called clpbar, not bar. https://repology.org/metapackage/clpbar/versions If you want bar, I think you want http://www.theiling.de/projects/bar.html

@rdnetto
Copy link
Contributor Author

rdnetto commented Mar 15, 2018

From looking at that link, it's called bar under every major distro except Fedora and Arch. IMO, it would be preferable to keep the same name to ensure consistency, esp. since that's a good indicator of what package most people associate with the name.

That said, if you feel strongly about it I'm happy to rename it.

@ryantm
Copy link
Member

ryantm commented Mar 15, 2018

Oh, I didn't notice that name column, sorry. I remove my objection.

@nlewo
Copy link
Member

nlewo commented Mar 17, 2018

@GrahamcOfBorg build bar

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bar

Partial log (click to expand)

make[1]: Leaving directory '/build/bar-1.11.1'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/84n2m5rcq7sd5qfg0yr5234q3y84n6hy-bar-1.11.1
shrinking /nix/store/84n2m5rcq7sd5qfg0yr5234q3y84n6hy-bar-1.11.1/bin/bar
gzipping man pages under /nix/store/84n2m5rcq7sd5qfg0yr5234q3y84n6hy-bar-1.11.1/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/84n2m5rcq7sd5qfg0yr5234q3y84n6hy-bar-1.11.1/bin
patching script interpreter paths in /nix/store/84n2m5rcq7sd5qfg0yr5234q3y84n6hy-bar-1.11.1
checking for references to /build in /nix/store/84n2m5rcq7sd5qfg0yr5234q3y84n6hy-bar-1.11.1...
/nix/store/84n2m5rcq7sd5qfg0yr5234q3y84n6hy-bar-1.11.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bar

Partial log (click to expand)

make[1]: Leaving directory '/build/bar-1.11.1'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/irlsxzabsa6133vlwi6m0m15gmrlf5xg-bar-1.11.1
shrinking /nix/store/irlsxzabsa6133vlwi6m0m15gmrlf5xg-bar-1.11.1/bin/bar
gzipping man pages under /nix/store/irlsxzabsa6133vlwi6m0m15gmrlf5xg-bar-1.11.1/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/irlsxzabsa6133vlwi6m0m15gmrlf5xg-bar-1.11.1/bin
patching script interpreter paths in /nix/store/irlsxzabsa6133vlwi6m0m15gmrlf5xg-bar-1.11.1
checking for references to /build in /nix/store/irlsxzabsa6133vlwi6m0m15gmrlf5xg-bar-1.11.1...
/nix/store/irlsxzabsa6133vlwi6m0m15gmrlf5xg-bar-1.11.1

@nlewo
Copy link
Member

nlewo commented Mar 18, 2018

Thanks

@nlewo nlewo merged commit 782fbc6 into NixOS:master Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rdnetto @ryantm @nlewo @GrahamcOfBorg