Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glm: fix darwin build #37000

Merged
merged 1 commit into from Mar 14, 2018
Merged

glm: fix darwin build #37000

merged 1 commit into from Mar 14, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Mar 14, 2018

@GrahamcOfBorg build glm

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: glm

Partial log (click to expand)

Patching '/nix/store/dhz8m6was22w9igi51c2m8z8qh2mp5zq-glm-0.9.8.5/lib/pkgconfig/glm.pc' includedir to output /nix/store/dhz8m6was22w9igi51c2m8z8qh2mp5zq-glm-0.9.8.5
shrinking RPATHs of ELF executables and libraries in /nix/store/dhz8m6was22w9igi51c2m8z8qh2mp5zq-glm-0.9.8.5
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dhz8m6was22w9igi51c2m8z8qh2mp5zq-glm-0.9.8.5/lib 
patching script interpreter paths in /nix/store/dhz8m6was22w9igi51c2m8z8qh2mp5zq-glm-0.9.8.5
checking for references to /tmp/nix-build-glm-0.9.8.5.drv-0 in /nix/store/dhz8m6was22w9igi51c2m8z8qh2mp5zq-glm-0.9.8.5...
shrinking RPATHs of ELF executables and libraries in /nix/store/90a99v2lfgga6487vgy98s735sv65plp-glm-0.9.8.5-doc
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/90a99v2lfgga6487vgy98s735sv65plp-glm-0.9.8.5-doc
checking for references to /tmp/nix-build-glm-0.9.8.5.drv-0 in /nix/store/90a99v2lfgga6487vgy98s735sv65plp-glm-0.9.8.5-doc...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: glm

Partial log (click to expand)

Patching '/nix/store/r16mprimbvf20xqshhr9cj6fw1kwxb0n-glm-0.9.8.5/lib/pkgconfig/glm.pc' includedir to output /nix/store/r16mprimbvf20xqshhr9cj6fw1kwxb0n-glm-0.9.8.5
shrinking RPATHs of ELF executables and libraries in /nix/store/r16mprimbvf20xqshhr9cj6fw1kwxb0n-glm-0.9.8.5
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/r16mprimbvf20xqshhr9cj6fw1kwxb0n-glm-0.9.8.5/lib
patching script interpreter paths in /nix/store/r16mprimbvf20xqshhr9cj6fw1kwxb0n-glm-0.9.8.5
checking for references to /build in /nix/store/r16mprimbvf20xqshhr9cj6fw1kwxb0n-glm-0.9.8.5...
shrinking RPATHs of ELF executables and libraries in /nix/store/v9xm4gah9vqsfn6zm5h1gw7fv87jnzdh-glm-0.9.8.5-doc
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/v9xm4gah9vqsfn6zm5h1gw7fv87jnzdh-glm-0.9.8.5-doc
checking for references to /build in /nix/store/v9xm4gah9vqsfn6zm5h1gw7fv87jnzdh-glm-0.9.8.5-doc...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: glm

Partial log (click to expand)

'/private/tmp/nix-build-glm-0.9.8.5.drv-0/source/doc/theme' -> '/nix/store/nr1x2p751n7m4mrkp3623zimd4ll1pv4-glm-0.9.8.5-doc/share/doc/glm/theme'
'/private/tmp/nix-build-glm-0.9.8.5.drv-0/source/doc/theme/doxygen.css' -> '/nix/store/nr1x2p751n7m4mrkp3623zimd4ll1pv4-glm-0.9.8.5-doc/share/doc/glm/theme/doxygen.css'
'/private/tmp/nix-build-glm-0.9.8.5.drv-0/source/doc/theme/tabs.css' -> '/nix/store/nr1x2p751n7m4mrkp3623zimd4ll1pv4-glm-0.9.8.5-doc/share/doc/glm/theme/tabs.css'
post-installation fixup
Patching '/nix/store/212bhx934fghh1i26rx6xlch4jiq619w-glm-0.9.8.5/lib/pkgconfig/glm.pc' includedir to output /nix/store/212bhx934fghh1i26rx6xlch4jiq619w-glm-0.9.8.5
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/212bhx934fghh1i26rx6xlch4jiq619w-glm-0.9.8.5/lib
patching script interpreter paths in /nix/store/212bhx934fghh1i26rx6xlch4jiq619w-glm-0.9.8.5
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/nr1x2p751n7m4mrkp3623zimd4ll1pv4-glm-0.9.8.5-doc

LnL7
LnL7 approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit 212d028 into NixOS:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @LnL7 @GrahamcOfBorg