Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2018.03.10 -> 2018.03.14 #37003

Merged
merged 1 commit into from Mar 14, 2018
Merged

youtube-dl: 2018.03.10 -> 2018.03.14 #37003

merged 1 commit into from Mar 14, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Mar 14, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

dotlambda
dotlambda reviewed Mar 14, 2018
View reviewed changes
pkgs/tools/misc/youtube-dl/default.nix Outdated
@@ -16,11 +16,11 @@ with stdenv.lib;
buildPythonApplication rec {

name = "youtube-dl-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pname

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotlambda What do you mean?

Copy link
Member

@dotlambda dotlambda Mar 14, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop the name and set pname = "youtube-dl". This makes it easier to override the version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, but it doesn't build:

error: undefined variable 'name' at /home/bart/source/nixpkgs/pkgs/tools/misc/youtube-dl/default.nix:22:53

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because ${name} is used in the url. You'll have to replace it by ${pname}-${version}.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

dotlambda
dotlambda reviewed Mar 14, 2018
View reviewed changes
pkgs/tools/misc/youtube-dl/default.nix Outdated
@@ -15,12 +15,12 @@
with stdenv.lib;
buildPythonApplication rec {

name = "youtube-dl-${version}";
version = "2018.03.10";
pname = "youtube-dl-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No version in here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dotlambda
Copy link
Member

@GrahamcOfBorg build youtube-dl

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.3.14
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zwsg64cs0mcaam4vgpxjnll1c243539q-youtube-dl-2018.03.14
gzipping man pages under /nix/store/zwsg64cs0mcaam4vgpxjnll1c243539q-youtube-dl-2018.03.14/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zwsg64cs0mcaam4vgpxjnll1c243539q-youtube-dl-2018.03.14/lib  /nix/store/zwsg64cs0mcaam4vgpxjnll1c243539q-youtube-dl-2018.03.14/bin
patching script interpreter paths in /nix/store/zwsg64cs0mcaam4vgpxjnll1c243539q-youtube-dl-2018.03.14
checking for references to /build in /nix/store/zwsg64cs0mcaam4vgpxjnll1c243539q-youtube-dl-2018.03.14...
wrapping `/nix/store/zwsg64cs0mcaam4vgpxjnll1c243539q-youtube-dl-2018.03.14/bin/youtube-dl'...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.3.14
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v1hhmlxksc3gbxn1sh78xldl440m0mxs-youtube-dl-2018.03.14
gzipping man pages under /nix/store/v1hhmlxksc3gbxn1sh78xldl440m0mxs-youtube-dl-2018.03.14/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/v1hhmlxksc3gbxn1sh78xldl440m0mxs-youtube-dl-2018.03.14/lib  /nix/store/v1hhmlxksc3gbxn1sh78xldl440m0mxs-youtube-dl-2018.03.14/bin
patching script interpreter paths in /nix/store/v1hhmlxksc3gbxn1sh78xldl440m0mxs-youtube-dl-2018.03.14
checking for references to /build in /nix/store/v1hhmlxksc3gbxn1sh78xldl440m0mxs-youtube-dl-2018.03.14...
wrapping `/nix/store/v1hhmlxksc3gbxn1sh78xldl440m0mxs-youtube-dl-2018.03.14/bin/youtube-dl'...

@dotlambda dotlambda merged commit 84b0016 into NixOS:master Mar 14, 2018
@magnetophon magnetophon deleted the youtube-dl branch March 15, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @dotlambda @GrahamcOfBorg