Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pycurl: Fix darwin build #37008

Merged
merged 1 commit into from Mar 14, 2018
Merged

pythonPackages.pycurl: Fix darwin build #37008

merged 1 commit into from Mar 14, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp requested a review from FRidh as a code owner March 14, 2018 19:00
@LnL7
Copy link
Member

LnL7 commented Mar 14, 2018

@GrahamcOfBorg build pythonPackages.pycurl

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.pycurl

Partial log (click to expand)

tests/write_to_stringio_test.py .s                                       [100%]

=============================== warnings summary ===============================
tests/setopt_lifecycle_test.py::TestString
  cannot collect test class 'TestString' because it has a __new__ constructor

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 2 tests deselected ==============================
======= 184 passed, 7 skipped, 2 deselected, 1 warnings in 13.89 seconds =======
/nix/store/sc2zaygahgfm520d5w98i4drndib87c3-python2.7-pycurl-7.19.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.pycurl

Partial log (click to expand)

tests/write_to_stringio_test.py .s                                       [100%]

=============================== warnings summary ===============================
tests/setopt_lifecycle_test.py::TestString
  cannot collect test class 'TestString' because it has a __new__ constructor

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 2 tests deselected ==============================
======= 184 passed, 7 skipped, 2 deselected, 1 warnings in 16.43 seconds =======
/nix/store/y11k7vhh53afz09l5909rcadsrm7nxw9-python2.7-pycurl-7.19.5.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.pycurl

Partial log (click to expand)

tests/write_to_stringio_test.py .s                                       [100%]

=============================== warnings summary ===============================
tests/setopt_lifecycle_test.py::TestString
  cannot collect test class 'TestString' because it has a __new__ constructor

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 2 tests deselected ==============================
======= 184 passed, 7 skipped, 2 deselected, 1 warnings in 42.06 seconds =======
/nix/store/f3wamir0aav8ifziz4ghmpqlpwi6970i-python2.7-pycurl-7.19.5.1

dotlambda
dotlambda requested changes Mar 14, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind moving the expresssion out of python-packages.nix?

@LnL7 LnL7 merged commit f18a23a into NixOS:master Mar 14, 2018
@dotlambda dotlambda mentioned this pull request Mar 18, 2018
Merged
8 tasks
@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.pycurl

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.pycurl

Partial log (click to expand)

/nix/store/9ck0p6rjqbl73i76g9rb7yrjp62zbdz6-python3.6-pycurl-7.43.0.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python3.pkgs.pycurl

Partial log (click to expand)

=============================== warnings summary ===============================
tests/setopt_lifecycle_test.py::TestString
  cannot collect test class 'TestString' because it has a __new__ constructor

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 6 tests deselected ==============================
== 8 failed, 334 passed, 5 skipped, 6 deselected, 1 warnings in 59.75 seconds ==
part1part2
builder for '/nix/store/y3vh4crcy7mkrs347cg4vvw7jfwa5amn-python3.6-pycurl-7.43.0.1.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/y3vh4crcy7mkrs347cg4vvw7jfwa5amn-python3.6-pycurl-7.43.0.1.drv' failed

@dotlambda
Copy link
Member

dotlambda commented Mar 18, 2018 •
edited

@knedlsepp @LnL7 There seems to be a problem with Python 3.

@knedlsepp
Copy link
Member Author

Oh. Will look into solving this ASAP

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pycurl

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pycurl

Partial log (click to expand)

/nix/store/lkc8lvs2dmxkwxqmhmaadwi2ad82a5n2-python2.7-pycurl-7.43.0.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.pycurl

Partial log (click to expand)

Using /build/pycurl-7.43.0.1/tests/fake-curl/curl-config-empty ()
=============================== warnings summary ===============================
tests/setopt_lifecycle_test.py::TestString
  cannot collect test class 'TestString' because it has a __new__ constructor

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================== 6 tests deselected ==============================
== 4 failed, 339 passed, 7 skipped, 6 deselected, 1 warnings in 67.78 seconds ==
builder for '/nix/store/fnh74x3xp3znp2ck2hxr1lwihynmzw12-python2.7-pycurl-7.43.0.1.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/fnh74x3xp3znp2ck2hxr1lwihynmzw12-python2.7-pycurl-7.43.0.1.drv' failed

@dotlambda
Copy link
Member

That's strange: Before, it was

======= 184 passed, 7 skipped, 2 deselected, 1 warnings in 42.06 seconds =======

Now we get

== 4 failed, 339 passed, 7 skipped, 6 deselected, 1 warnings in 67.78 seconds ==

Where are the additional tests coming from?

So, it's not a problem with Python 3.

@knedlsepp
Copy link
Member Author

Yup. checkPhase doesn't succeed with python3. Let's just disable failing tests for now.

@knedlsepp knedlsepp mentioned this pull request Mar 18, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@LnL7 LnL7 LnL7 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knedlsepp @LnL7 @GrahamcOfBorg @dotlambda