Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freenect: 0.5.5 -> 0.5.7, Enable Darwin #37033

Merged
merged 2 commits into from Mar 18, 2018
Merged

freenect: 0.5.5 -> 0.5.7, Enable Darwin #37033

merged 2 commits into from Mar 18, 2018

Conversation

lukeadams
Copy link
Contributor

Motivation for this change

Version bump which fixes issues with device scanning.

Also enabled support for Darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 15, 2018

@GrahamcOfBorg build freenect

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: freenect

Partial log (click to expand)

shrinking /nix/store/z33rm4l60idmn2jlmsvhw2pwmx3pv527-freenect-0.5.7/lib/libfreenect_sync.so.0.5.5
shrinking /nix/store/z33rm4l60idmn2jlmsvhw2pwmx3pv527-freenect-0.5.7/lib/fakenect/libfakenect.so.0.5.5
shrinking /nix/store/z33rm4l60idmn2jlmsvhw2pwmx3pv527-freenect-0.5.7/lib/libfreenect.so.0.5.5
gzipping man pages under /nix/store/z33rm4l60idmn2jlmsvhw2pwmx3pv527-freenect-0.5.7/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/z33rm4l60idmn2jlmsvhw2pwmx3pv527-freenect-0.5.7/lib  /nix/store/z33rm4l60idmn2jlmsvhw2pwmx3pv527-freenect-0.5.7/bin
patching script interpreter paths in /nix/store/z33rm4l60idmn2jlmsvhw2pwmx3pv527-freenect-0.5.7
/nix/store/z33rm4l60idmn2jlmsvhw2pwmx3pv527-freenect-0.5.7/bin/fakenect: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/z33rm4l60idmn2jlmsvhw2pwmx3pv527-freenect-0.5.7...
/nix/store/z33rm4l60idmn2jlmsvhw2pwmx3pv527-freenect-0.5.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: freenect

Partial log (click to expand)

shrinking /nix/store/6g9b1x58pvc4x2vdxvm7a1jv3v8i3j57-freenect-0.5.7/lib/libfreenect_sync.so.0.5.5
shrinking /nix/store/6g9b1x58pvc4x2vdxvm7a1jv3v8i3j57-freenect-0.5.7/lib/fakenect/libfakenect.so.0.5.5
shrinking /nix/store/6g9b1x58pvc4x2vdxvm7a1jv3v8i3j57-freenect-0.5.7/lib/libfreenect.so.0.5.5
gzipping man pages under /nix/store/6g9b1x58pvc4x2vdxvm7a1jv3v8i3j57-freenect-0.5.7/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/6g9b1x58pvc4x2vdxvm7a1jv3v8i3j57-freenect-0.5.7/lib  /nix/store/6g9b1x58pvc4x2vdxvm7a1jv3v8i3j57-freenect-0.5.7/bin
patching script interpreter paths in /nix/store/6g9b1x58pvc4x2vdxvm7a1jv3v8i3j57-freenect-0.5.7
/nix/store/6g9b1x58pvc4x2vdxvm7a1jv3v8i3j57-freenect-0.5.7/bin/fakenect: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/6g9b1x58pvc4x2vdxvm7a1jv3v8i3j57-freenect-0.5.7...
/nix/store/6g9b1x58pvc4x2vdxvm7a1jv3v8i3j57-freenect-0.5.7

@lukeadams lukeadams changed the title Freenect update freenect: 0.5.5 -> 0.5.7, Enable Darwin Mar 15, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: freenect

Partial log (click to expand)

/nix/store/v8g2fsf5ks6wv039jbp1wnkz53y3cll5-freenect-0.5.7/lib/fakenect/libfakenect.0.5.5.dylib: fixing dylib
/nix/store/v8g2fsf5ks6wv039jbp1wnkz53y3cll5-freenect-0.5.7/lib/libfreenect_sync.0.5.5.dylib: fixing dylib
/nix/store/v8g2fsf5ks6wv039jbp1wnkz53y3cll5-freenect-0.5.7/lib/libfreenect.0.5.5.dylib: fixing dylib
/nix/store/v8g2fsf5ks6wv039jbp1wnkz53y3cll5-freenect-0.5.7/lib/fakenect/libfakenect.0.5.5.dylib: fixing dylib
/nix/store/v8g2fsf5ks6wv039jbp1wnkz53y3cll5-freenect-0.5.7/lib/libfreenect_sync.0.5.5.dylib: fixing dylib
/nix/store/v8g2fsf5ks6wv039jbp1wnkz53y3cll5-freenect-0.5.7/lib/libfreenect.0.5.5.dylib: fixing dylib
/nix/store/v8g2fsf5ks6wv039jbp1wnkz53y3cll5-freenect-0.5.7/lib/fakenect/libfakenect.0.5.5.dylib: fixing dylib
/nix/store/v8g2fsf5ks6wv039jbp1wnkz53y3cll5-freenect-0.5.7/lib/libfreenect_sync.0.5.5.dylib: fixing dylib
/nix/store/v8g2fsf5ks6wv039jbp1wnkz53y3cll5-freenect-0.5.7/lib/libfreenect.0.5.5.dylib: fixing dylib
/nix/store/v8g2fsf5ks6wv039jbp1wnkz53y3cll5-freenect-0.5.7

@Mic92 Mic92 merged commit bcddd8b into NixOS:master Mar 18, 2018
@lukeadams
Copy link
Contributor Author

Note: there are sporadic segfaults when detecting kinect devices, but running the program (e.g. freenect-cppview) multiple times eventually works. I think this is due to this package using system CoreFoundation while libusb uses a nix-provided one. I'll submit a patch this weekend.

@lukeadams lukeadams deleted the freenect-update branch May 26, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukeadams @ryantm @GrahamcOfBorg @Mic92