Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod not being added to modpack #158

Closed
Cy4nX opened this issue Jun 8, 2016 · 6 comments · Fixed by #324
Closed

Mod not being added to modpack #158

Cy4nX opened this issue Jun 8, 2016 · 6 comments · Fixed by #324
Labels
Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Normal Type: Bug

Comments

@Cy4nX
Copy link

Cy4nX commented Jun 8, 2016

Description:

When I tried to put a mod into my modpack, nothing happened. Is this a bug or am I just doing it wrong?

Reproduction Steps:

  1. I copied the name of the mod word for word (Astroniki Sunflare for Scatterer)
  2. I pasted it in the 'Mod Name...' box on the 'Edit Pack' page
  3. I clicked the 'Add Mod' button
  4. It sent me to the page for the modpack... WITH NO MOD!

Expectations:

The mod would be added to the modpack

Environment:

Google Chrome v50.0.2661.102 (64-bit)
Mac OS X v10.10.5

Screenshots:

screen shot 2016-06-08 at 15 41 05

screen shot 2016-06-08 at 15 42 14

screen shot 2016-06-08 at 15 42 41
@StollD
Copy link
Member

StollD commented Jun 8, 2016

Not exactly sure, but have you tried the Mod ID? (from the URL to the mod site)

@Cy4nX
Copy link
Author

Cy4nX commented Jun 8, 2016

So, the 408 from http://spacedock.info/mod/408/Astroniki%20Sunflare%20for%20Scatterer?

Because that didn't work either.

@OzfurAtlas
Copy link

same problem with me. It just really sucks having to download 50+ mods individualy

@qhenckel
Copy link

I am getting the same problem. I get this error in the javascript console when I click "edit pack"
Uncaught ReferenceError: Editor is not defined at edit_pack.js:10 at edit_pack.js:167

@LegoCollecter14
Copy link

I too am having this issue

Sorry, something went wrong.

@HebaruSan
Copy link
Contributor

It looks like the mod selection functionality is very heavily dependent on the dropdown.

  1. Start typing the name of the mod
  2. Wait till a dropdown list of mods appears under the entry field
    image
  3. Select the right one from the list
  4. Now click Add Mod
  5. Repeat if you like
  6. Click Save Changes

Pasting the mod name or any other flow that doesn't involve clicking in the dropdown will probably always fail.

The Add Mod button does nothing if new_mod isn't set:

SpaceDock/frontend/coffee/edit_pack.coffee

Lines 59 to 63 in e918944

document.getElementById('add-mod-button').addEventListener('click', (e) ->
e.preventDefault()
if new_mod == null
# TODO: error
return

And it's only set by the user making a selection in the type-ahead:

SpaceDock/frontend/coffee/edit_pack.coffee

Lines 51 to 57 in e918944

$("#mod-typeahead").typeahead(null, {
displayKey: 'name',
source: engine.ttAdapter()
}).on("typeahead:selected typeahead:autocompleted", (e, m) ->
new_mod = m
)
)

@HebaruSan HebaruSan added Priority: Normal Type: Bug Area: Frontend Related to HTML, JS, CSS, or other browser things labels Jun 25, 2020
@HebaruSan HebaruSan mentioned this issue Jun 26, 2020
Merged
@HebaruSan HebaruSan mentioned this issue Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Normal Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

β → 🜚🏭 ② KSP-SpaceDock/SpaceDock
6 participants
@HebaruSan @qhenckel @StollD @Cy4nX @LegoCollecter14 @OzfurAtlas