openorienteering-mapper: 0.8.1 -> 0.8.1.2 and fix templates #38526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crashes on darwin
jtojnar
reviewed
Apr 6, 2018
| @@ -47,8 +48,10 @@ stdenv.mkDerivation rec { | |||
| stdenv.lib.optionalString stdenv.isDarwin '' | |||
| # Fixes "This application failed to start because it could not find or load the Qt | |||
| # platform plugin "cocoa"." | |||
| echo ${qtimageformats}/${qtbase.qtPluginPrefix} | |||
There was a problem hiding this comment.
Woops, removed that now. Thanks.
This allows tiff images to be loaded correctly as templates.
|
Builds on NixOS, but attempting to run complains about an incompatible QT library. That's probably why it was marked Mac-only. |
|
The QT error is recurring issue, not anything to do with this PR. See for example #17448 |
|
The package should work fine with NixOS but I haven't tested it hence why the attribute is not set. |
GrahamcOfBorg
added
8.has: package (new)
10.rebuild-linux: 1-10
and removed
10.rebuild-linux: 0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Version bump and fix an issue with reading template files.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)