nixos/nginx: fix gitweb submodule #38527
Conversation
| }; | ||
|
|
||
| services.nginx = { | ||
| virtualHosts.default = { | ||
| locations."/gitweb" = { | ||
| root = "${pkgs.git}/share/gitweb"; | ||
| locations."/gitweb/" = { |
There was a problem hiding this comment.
Should you also add a redirect from /gitweb to /gitweb/?
| extraConfig = '' | ||
| include ${pkgs.nginx}/conf/fastcgi_params; | ||
| fastcgi_param GITWEB_CONFIG ${cfg.gitwebConfigFile}; | ||
| fastcgi_pass unix:/run/gitweb.sock; | ||
| fastcgi_pass unix:/run/gitweb/gitweb.sock; |
There was a problem hiding this comment.
I don't really understand this change, so gitweb was trying to create its own socket?
Also, the previous socket was owned by nginx, and this one?
There was a problem hiding this comment.
@wmertens Before this PR systemd does socket magic, after this PR gitweb does it itself (I didn't know its able to do that - its not part of gitweb docs but part of CGI::Fast library docs which gitweb uses for fastcgi mode).
Socket is still owned by nginx, since gitweb is run under nginx user. And with RuntimeDirectory systemd creates /run/gitweb folder with nginx owner, so gitweb is allowed to write socket there.
|
👍 Good stuff! |
|
@wmertens Thank you! |
ghost
deleted the
Motivation for this change
Correct issues
CGI::Fastused by gitweb can create socket by its ownFCGI::ProcManager, otherwise gitweb will stop functioning under burst loads in case of error conditionscc @wmertens
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)