Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssh_hpn: 7.5p1 -> 7.6p1 #38534

Merged
merged 1 commit into from Apr 8, 2018
Merged

openssh_hpn: 7.5p1 -> 7.6p1 #38534

merged 1 commit into from Apr 8, 2018

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Apr 6, 2018 •
edited

Motivation for this change

Ping @fadenb

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openssh_hpn

Partial log (click to expand)

shrinking /nix/store/ysyg6046217p9xd4c0inaf1x16gqf1gi-openssh-7.6p1/libexec/ssh-keysign
shrinking /nix/store/ysyg6046217p9xd4c0inaf1x16gqf1gi-openssh-7.6p1/libexec/ssh-pkcs11-helper
shrinking /nix/store/ysyg6046217p9xd4c0inaf1x16gqf1gi-openssh-7.6p1/libexec/sftp-server
gzipping man pages under /nix/store/ysyg6046217p9xd4c0inaf1x16gqf1gi-openssh-7.6p1/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ysyg6046217p9xd4c0inaf1x16gqf1gi-openssh-7.6p1/libexec  /nix/store/ysyg6046217p9xd4c0inaf1x16gqf1gi-openssh-7.6p1/bin
patching script interpreter paths in /nix/store/ysyg6046217p9xd4c0inaf1x16gqf1gi-openssh-7.6p1
/nix/store/ysyg6046217p9xd4c0inaf1x16gqf1gi-openssh-7.6p1/bin/ssh-copy-id: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/ysyg6046217p9xd4c0inaf1x16gqf1gi-openssh-7.6p1...
/nix/store/ysyg6046217p9xd4c0inaf1x16gqf1gi-openssh-7.6p1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openssh_hpn

Partial log (click to expand)

shrinking /nix/store/3xp9yrhn3sab3r9qc77mc890yc5k9v21-openssh-7.6p1/bin/ssh-add
shrinking /nix/store/3xp9yrhn3sab3r9qc77mc890yc5k9v21-openssh-7.6p1/bin/scp
shrinking /nix/store/3xp9yrhn3sab3r9qc77mc890yc5k9v21-openssh-7.6p1/bin/ssh
gzipping man pages under /nix/store/3xp9yrhn3sab3r9qc77mc890yc5k9v21-openssh-7.6p1/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3xp9yrhn3sab3r9qc77mc890yc5k9v21-openssh-7.6p1/libexec  /nix/store/3xp9yrhn3sab3r9qc77mc890yc5k9v21-openssh-7.6p1/bin
patching script interpreter paths in /nix/store/3xp9yrhn3sab3r9qc77mc890yc5k9v21-openssh-7.6p1
/nix/store/3xp9yrhn3sab3r9qc77mc890yc5k9v21-openssh-7.6p1/bin/ssh-copy-id: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/3xp9yrhn3sab3r9qc77mc890yc5k9v21-openssh-7.6p1...
/nix/store/3xp9yrhn3sab3r9qc77mc890yc5k9v21-openssh-7.6p1

fadenb
fadenb approved these changes Apr 7, 2018
View reviewed changes
Copy link
Contributor

@fadenb fadenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I am currently not using openssh_hpn so I can not do proper tests at the moment.

@Mic92 Mic92 merged commit 314f90b into NixOS:master Apr 8, 2018
@infinisil infinisil deleted the update/openssh_hpn branch April 18, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadenb fadenb fadenb approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@infinisil @GrahamcOfBorg @fadenb @Mic92