duplicati: init at 2.0.3.3 #38533

nyanloutre · 2018-04-06T22:08:20Z

Motivation for this change

Creation of a Duplicati package, a very nice backup tool that I use regularly.
This is my first package pull request so I might have forgotten some things.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

infinisil

Nice first PR, well done!

In addition to my review comments, something you should do is split this change up into 2 commits: One for the package, and one for the service.

infinisil · 2018-04-06T22:56:23Z

pkgs/tools/backup/duplicati/default.nix

+  channel = "beta";
+  build_date = "2018-04-02";
+
+  src = fetchurl {


You can use fetchzip instead, then the sourceRoot and unzip as build input isn't needed.

infinisil · 2018-04-06T22:59:08Z

nixos/modules/services/backup/duplicati.nix

+      '';
+
+      serviceConfig = {
+        Type = "simple";


This is the default, you can omit this

infinisil · 2018-04-06T23:01:41Z

nixos/modules/services/backup/duplicati.nix

+        }
+        chown -R duplicati:duplicati /var/lib/duplicati/
+        chmod 0700 /var/lib/duplicati/
+      '';


You can add createHome = true to the user declaration, then all of this is done automatically for you and you can omit preStart and PermissionsStartOnly.

infinisil · 2018-04-06T23:07:27Z

nixos/modules/services/backup/duplicati.nix

@@ -0,0 +1,48 @@
+{ config, pkgs, lib, mono, ... }:


mono argument unused

jtojnar · 2018-04-07T01:57:10Z

pkgs/tools/backup/duplicati/default.nix

@@ -0,0 +1,34 @@
+{ stdenv, fetchurl, mono, sqlite, makeWrapper, unzip }:
+
+stdenv.mkDerivation rec {


Could you try building it from source?

Yes, I want to do this in a following update to the package. Since it is my first attempt to create a package I wanted to start simple and improve later on.

Default Makefile is using nuget to fetch dependencies, and it seems that it is not possible for a Nix build to fetch things from the internet during the build. I don't know enough about C# builds to know how this could work, so someone with more knowledge on this subject could help (maybe I should create an issue ?)

nyanloutre · 2018-04-07T10:54:25Z

@infinisil I think I completed all your requests !

infinisil

A couple minor things

Now I enabled this service on my machine, but how do you actually use it? Going to http://localhost:8200 doesn't give me anything.

infinisil · 2018-04-07T15:51:31Z

pkgs/tools/backup/duplicati/default.nix

+  src = fetchzip {
+    url = "https://github.com/duplicati/duplicati/releases/download/v${version}-${version}_${channel}_${build_date}/duplicati-${version}_${channel}_${build_date}.zip";
+    sha256 = "0hwdpsgrvm3gq648mg9g0z0rk49g71dd8r5i1a8w83pwdqv0hn9c";
+    stripRoot=false;


Nitpick: Spaces around =

infinisil · 2018-04-07T15:52:07Z

pkgs/tools/backup/duplicati/default.nix

+
+  installPhase = ''
+    mkdir -p $out/{bin,share/${name}}
+    cp -r * $out/share/${name}/.


Another nitpick: I don't think the /. at the end is needed

infinisil · 2018-04-07T16:16:35Z

pkgs/tools/backup/duplicati/default.nix

+  installPhase = ''
+    mkdir -p $out/{bin,share/${name}}
+    cp -r * $out/share/${name}/.
+    makeWrapper "${mono}/bin/mono" $out/bin/Duplicati \


From the manual I see that the normal command name is duplicati-cli, I don't really care about the -cli suffix, but it would be nice for it to be lowercased. (I just struggled trying to run it for 5 minutes before realizing it's upper case in the current version).

The idea was to make it work like the AUR package, which means a service run in a systemd unit and listen on port 8200. All the configuration is then made in the web UI.

But you are right, I should add the duplicati-cli

infinisil · 2018-04-07T16:19:50Z

nixos/modules/services/backup/duplicati.nix

+      serviceConfig = {
+        User = "duplicati";
+        Group = "duplicati";
+        ExecStart = "${pkgs.duplicati}/bin/Duplicati --webservice-interface=any --webservice-port=8200 --server-datafolder=/var/lib/duplicati";


Using these defaults (bind to any interface, listen on 8200 and this data directory) is probably fine for now, the module could be extended to have options for these later on if people need it.

Yes I wanted to do it once the package is working

nyanloutre · 2018-04-07T17:23:59Z

@infinisil I just pushed the fixes

infinisil · 2018-04-07T18:46:25Z

Ah nice, I'm still not exactly sure how it's supposed to be used, but having duplicati-cli and -server makes much more sense, and the binaries don't segfault so that's good. One last thing from my side: The duplicati package probably should be installed when you have the service enabled: environment.systemPackages = [ pkgs.duplicati ];

Otherwise this looks good and ready for merging :)

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 6, 2018

infinisil requested changes Apr 6, 2018

View reviewed changes

jtojnar reviewed Apr 7, 2018

View reviewed changes

nyanloutre force-pushed the duplicati-package branch 5 times, most recently from 4cbe6d7 to 6bd4604 Compare April 7, 2018 10:48

infinisil requested changes Apr 7, 2018

View reviewed changes

nyanloutre force-pushed the duplicati-package branch from 6bd4604 to 059330c Compare April 7, 2018 17:15

duplicati: init at 2.0.3.3

20f18c7

nyanloutre force-pushed the duplicati-package branch from 059330c to f5330af Compare April 7, 2018 17:43

duplicati: create service

b3aa9ec

nyanloutre force-pushed the duplicati-package branch from f5330af to b3aa9ec Compare April 7, 2018 19:23

infinisil approved these changes Apr 7, 2018

View reviewed changes

matthewbauer merged commit 1381606 into NixOS:master Apr 9, 2018

nyanloutre deleted the duplicati-package branch June 9, 2018 10:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

duplicati: init at 2.0.3.3 #38533

duplicati: init at 2.0.3.3 #38533

nyanloutre commented Apr 6, 2018 •

edited

infinisil left a comment

infinisil Apr 6, 2018

infinisil Apr 6, 2018

infinisil Apr 6, 2018

infinisil Apr 6, 2018

jtojnar Apr 7, 2018

nyanloutre Apr 7, 2018

nyanloutre Apr 7, 2018

nyanloutre commented Apr 7, 2018

infinisil left a comment

infinisil Apr 7, 2018

infinisil Apr 7, 2018

infinisil Apr 7, 2018 •

edited

nyanloutre Apr 7, 2018 •

edited

infinisil Apr 7, 2018 •

edited

nyanloutre Apr 7, 2018

nyanloutre commented Apr 7, 2018

infinisil commented Apr 7, 2018

		@@ -0,0 +1,34 @@
		{ stdenv, fetchurl, mono, sqlite, makeWrapper, unzip }:

		stdenv.mkDerivation rec {

duplicati: init at 2.0.3.3 #38533

duplicati: init at 2.0.3.3 #38533

Conversation

nyanloutre commented Apr 6, 2018 • edited

Motivation for this change

Things done

infinisil left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nyanloutre commented Apr 7, 2018

infinisil left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

infinisil Apr 7, 2018 • edited

Choose a reason for hiding this comment

nyanloutre Apr 7, 2018 • edited

Choose a reason for hiding this comment

infinisil Apr 7, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nyanloutre commented Apr 7, 2018

infinisil commented Apr 7, 2018

nyanloutre commented Apr 6, 2018 •

edited

infinisil Apr 7, 2018 •

edited

nyanloutre Apr 7, 2018 •

edited

infinisil Apr 7, 2018 •

edited