Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spin: fix build #38542

Closed
wants to merge 1 commit into from
Closed

spin: fix build #38542

wants to merge 1 commit into from

Conversation

sifmelcara
Copy link
Member

@sifmelcara sifmelcara commented Apr 7, 2018 •
edited

Motivation for this change

It looks like upstream have fixed the issue that archive was compressed twice

cc @pSub

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@sifmelcara
spin: fix build
6c1d3c6 
upstream have fixed the issue that archive was compressed twice
@pSub pSub self-requested a review April 7, 2018 09:40
pSub
pSub reviewed Apr 7, 2018
View reviewed changes
Copy link
Member

@pSub pSub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just downloaded http://spinroot.com/spin/Src/spin648.tar.gz and it was still compressed twice.

@sifmelcara
Copy link
Member Author 

$ wget http://spinroot.com/spin/Src/spin648.tar.gz
--2018-04-07 18:20:11--  http://spinroot.com/spin/Src/spin648.tar.gz
Resolving spinroot.com (spinroot.com)... 104.28.11.21, 104.28.10.21, 2400:cb00:2048:1::681c:b15, ...
Connecting to spinroot.com (spinroot.com)|104.28.11.21|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: ‘spin648.tar.gz’

spin648.tar.gz                                           [      <=>                                                                                                             ] 531.86K   422KB/s    in 1.3s    

2018-04-07 18:20:13 (422 KB/s) - ‘spin648.tar.gz’ saved [544622]


$ sha256sum spin648.tar.gz 
0035bb114157a759e047c7f94ede0a3d7149003893914c9bbdff45e074ab6ae7  spin648.tar.gz

Do you have the same sha256sum ?

@sifmelcara
Copy link
Member Author

sifmelcara commented Apr 7, 2018 •
edited

By the way, I tried to download the archive, using multiple servers located in different Asia countries, and I got the same file (never experienced reCaptcha).

@pSub
Copy link
Member

pSub commented Apr 7, 2018 •
edited

This is strange. I've also tried to download the archive from different locations (all in Germany, where I live). However I'm always confronted with reCaptcha:

$ wget http://spinroot.com/spin/Src/spin648.tar.gz                 ~
--2018-04-07 15:59:10--  http://spinroot.com/spin/Src/spin648.tar.gz
Resolving spinroot.com (spinroot.com)... 104.28.11.21, 104.28.10.21, 2400:cb00:2048:1::681c:a15, ...
Connecting to spinroot.com (spinroot.com)|104.28.11.21|:80... connected.
HTTP request sent, awaiting response... 403 Forbidden
2018-04-07 15:59:10 ERROR 403: Forbidden.

After solving the captcha in a browser and downloading the archive I have an other archive then you.

$ sha256sum spin648.tar.gz                    
f092e880f31ff7e0cb12888a6e3ad851d5ebbb2b281fcb8208e21ce94afceae6  spin648.tar.gz

$ du -b spin648.tar.gz                                                      
544579	spin648.tar.gz

I'm really confused. We resolve the domain name to the same IP address and should therefore be connected to the same webserver (assuming there is no sort of cluster involved).

After unzipping the first layer I have the same archive as you.

$ gunzip -c spin648.tar.gz > spin.tar.gz                                               
$ sha256sum spin.tar.gz                                                                
0035bb114157a759e047c7f94ede0a3d7149003893914c9bbdff45e074ab6ae7  spin.tar.gz

@sifmelcara
Copy link
Member Author

Hmm...
I tried to use some free proxies on the internet to download the file ( wget -e use_proxy=yes -e http_proxy=$proxyurl http://spinroot.com/spin/Src/spin648.tar.gz), and indeed some proxies can download the file normally and some proxies got 403 forbidden.

Maybe we need to download from the dropbox mirror, which we used before

@pSub
Copy link
Member

pSub commented Apr 7, 2018

Yes. I just pushed a commit to use the dropbox mirror again. Thanks!

@pSub pSub closed this Apr 7, 2018
pSub added a commit that referenced this pull request Apr 7, 2018
@pSub
spin: switch back to dropbox mirror
95ece9e 
see #38542 for details
pSub added a commit that referenced this pull request Apr 7, 2018
@pSub
spin: switch back to dropbox mirror
3fa3293 
see #38542 for details

(cherry picked from commit 95ece9e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sifmelcara @pSub @GrahamcOfBorg