Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim-python: 0.2.3 -> 0.2.4 #37400

Merged
merged 1 commit into from Mar 20, 2018
Merged

neovim-python: 0.2.3 -> 0.2.4 #37400

merged 1 commit into from Mar 20, 2018

Conversation

teto
Copy link
Member

@teto teto commented Mar 20, 2018

required to work with latest deoplete for instance (else it prints error message)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto teto requested a review from FRidh as a code owner March 20, 2018 02:49
@teto teto mentioned this pull request Mar 20, 2018
Closed
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.neovim python3.pkgs.neovim

@teto I'd prefer if the commit message was pythonPackages.neovim: 0.2.3 -> 0.2.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.neovim, python3.pkgs.neovim

Partial log (click to expand)

Successfully installed neovim-0.2.4
/build/neovim-0.2.4
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ig4nl8h9h4r2rn77hbsrzvgkd102q871-python3.6-neovim-0.2.4
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ig4nl8h9h4r2rn77hbsrzvgkd102q871-python3.6-neovim-0.2.4/lib
patching script interpreter paths in /nix/store/ig4nl8h9h4r2rn77hbsrzvgkd102q871-python3.6-neovim-0.2.4
checking for references to /build in /nix/store/ig4nl8h9h4r2rn77hbsrzvgkd102q871-python3.6-neovim-0.2.4...
/nix/store/9dmbcsm5xrgqaqja8ak483j2nsk1xzpy-python2.7-neovim-0.2.4
/nix/store/ig4nl8h9h4r2rn77hbsrzvgkd102q871-python3.6-neovim-0.2.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.neovim, python3.pkgs.neovim

Partial log (click to expand)

checking for references to /build in /nix/store/zc07hraq95rzb8dzq99yk7a4qnlprpkw-python3.6-neovim-0.2.4...
/build/neovim-0.2.4
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hj5fndxv74jqpsgggn14i5x0way5cry3-python2.7-neovim-0.2.4
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hj5fndxv74jqpsgggn14i5x0way5cry3-python2.7-neovim-0.2.4/lib
patching script interpreter paths in /nix/store/hj5fndxv74jqpsgggn14i5x0way5cry3-python2.7-neovim-0.2.4
checking for references to /build in /nix/store/hj5fndxv74jqpsgggn14i5x0way5cry3-python2.7-neovim-0.2.4...
/nix/store/hj5fndxv74jqpsgggn14i5x0way5cry3-python2.7-neovim-0.2.4
/nix/store/zc07hraq95rzb8dzq99yk7a4qnlprpkw-python3.6-neovim-0.2.4

@teto
pythonPackages.neovim: 0.2.3 -> 0.2.4
366c79e 
required to work with latest deoplete for instance
@teto
Copy link
Member Author

teto commented Mar 20, 2018

@dotlambda indeed. message amended.

@dotlambda dotlambda merged commit b41c299 into NixOS:master Mar 20, 2018
@dotlambda
Copy link
Member

Should this be backported to 18.03?

@teto
Copy link
Member Author

teto commented Mar 20, 2018 via email

@dotlambda
Copy link
Member

Backported in 8337d1d

@teto teto deleted the neovim_python branch March 20, 2018 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @dotlambda @GrahamcOfBorg