Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hologram: 20170130 -> 20180319 #37393

Closed
wants to merge 1 commit into from
Closed

hologram: 20170130 -> 20180319 #37393

wants to merge 1 commit into from

Conversation

joelthompson
Copy link
Contributor

@joelthompson joelthompson commented Mar 19, 2018 •
edited

In AdRoll/hologram#62 support was added to hologram to configure
LDAP-based authorization of which roles a user was allowed to get
credentials for. This adds the ability to configure that.

Additionally, AdRoll/hologram#94 added support to customize the LDAP
group query, so this also feeds that configuration through.

Motivation for this change

Support new Hologram features

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joelthompson
hologram: Enable configuring LDAP authorization
c3a0890 
In AdRoll/hologram#62 support was added to hologram to configure
LDAP-based authorization of which roles a user was allowed to get
credentials for. This adds the ability to configure that.

Additionally, AdRoll/hologram/NixOS#94 added support to customize the LDAP
group query, so this also feeds that configuration through.
@Mic92
Copy link
Member

Mic92 commented Mar 19, 2018

@GrahamcOfBorg build hologram

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hologram

Partial log (click to expand)

/nix/store/4jln98aqiglx6p5975jd35kyfpzi70s4-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/build_osx_pkgs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/4jln98aqiglx6p5975jd35kyfpzi70s4-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/build_linux_pkgs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/4jln98aqiglx6p5975jd35kyfpzi70s4-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/docker/server/start.sh: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/4jln98aqiglx6p5975jd35kyfpzi70s4-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/docker/server/build-container.sh: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/4jln98aqiglx6p5975jd35kyfpzi70s4-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/hologram.sh: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/4jln98aqiglx6p5975jd35kyfpzi70s4-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/vendor/github.com/peterbourgon/g2s/fix.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/4jln98aqiglx6p5975jd35kyfpzi70s4-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/agent/support/darwin/postinstall.sh: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/4jln98aqiglx6p5975jd35kyfpzi70s4-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/agent/support/darwin/preinstall.sh: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/4jln98aqiglx6p5975jd35kyfpzi70s4-hologram-20180319-a7bab58...
/nix/store/q3srvdn1sc1j29qlncp5brg3w3a31xdc-hologram-20180319-a7bab58-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: hologram

Partial log (click to expand)

/nix/store/0ij3fw1jvfjdnm42s16gv4svv6klayaa-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/agent/support/darwin/postinstall.sh: interpreter directive changed from "/bin/sh" to "/nix/store/8hdxjv3m14jgdnawi5l0mz2h59qkk2g9-bash-4.4-p19/bin/sh"
/nix/store/0ij3fw1jvfjdnm42s16gv4svv6klayaa-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/agent/support/darwin/preinstall.sh: interpreter directive changed from "/bin/sh" to "/nix/store/8hdxjv3m14jgdnawi5l0mz2h59qkk2g9-bash-4.4-p19/bin/sh"
/nix/store/0ij3fw1jvfjdnm42s16gv4svv6klayaa-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/build_all_pkgs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8hdxjv3m14jgdnawi5l0mz2h59qkk2g9-bash-4.4-p19/bin/bash"
/nix/store/0ij3fw1jvfjdnm42s16gv4svv6klayaa-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/generate_docs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8hdxjv3m14jgdnawi5l0mz2h59qkk2g9-bash-4.4-p19/bin/bash"
/nix/store/0ij3fw1jvfjdnm42s16gv4svv6klayaa-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/compile_hologram.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8hdxjv3m14jgdnawi5l0mz2h59qkk2g9-bash-4.4-p19/bin/bash"
/nix/store/0ij3fw1jvfjdnm42s16gv4svv6klayaa-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/build_linux_pkgs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8hdxjv3m14jgdnawi5l0mz2h59qkk2g9-bash-4.4-p19/bin/bash"
/nix/store/0ij3fw1jvfjdnm42s16gv4svv6klayaa-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/build_osx_pkgs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8hdxjv3m14jgdnawi5l0mz2h59qkk2g9-bash-4.4-p19/bin/bash"
/nix/store/0ij3fw1jvfjdnm42s16gv4svv6klayaa-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/start.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8hdxjv3m14jgdnawi5l0mz2h59qkk2g9-bash-4.4-p19/bin/bash"
/nix/store/0ij3fw1jvfjdnm42s16gv4svv6klayaa-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/vendor/github.com/peterbourgon/g2s/fix.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8hdxjv3m14jgdnawi5l0mz2h59qkk2g9-bash-4.4-p19/bin/bash"
/nix/store/mxhsvjwc6p0ckhyp714dr9kzcdqagmkv-hologram-20180319-a7bab58-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: hologram

Partial log (click to expand)

/nix/store/phbhm4w5h7lgdfkqv254ndv6vvin9fdv-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/build_osx_pkgs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/phbhm4w5h7lgdfkqv254ndv6vvin9fdv-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/compile_hologram.sh: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/phbhm4w5h7lgdfkqv254ndv6vvin9fdv-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/generate_docs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/phbhm4w5h7lgdfkqv254ndv6vvin9fdv-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/buildscripts/start.sh: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/phbhm4w5h7lgdfkqv254ndv6vvin9fdv-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/docker/server/build-container.sh: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/phbhm4w5h7lgdfkqv254ndv6vvin9fdv-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/docker/server/start.sh: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
/nix/store/phbhm4w5h7lgdfkqv254ndv6vvin9fdv-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/hologram.sh: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/phbhm4w5h7lgdfkqv254ndv6vvin9fdv-hologram-20180319-a7bab58/share/go/src/github.com/AdRoll/hologram/vendor/github.com/peterbourgon/g2s/fix.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/phbhm4w5h7lgdfkqv254ndv6vvin9fdv-hologram-20180319-a7bab58...
/nix/store/jw8hva5nwbak3j602h0kp9klpjzr6703-hologram-20180319-a7bab58-bin

@joelthompson
Copy link
Contributor Author

Have now tested the build and service on NixOS and validated it works as expected.

@Mic92
Copy link
Member

Mic92 commented Mar 20, 2018 •
edited

merged in fe2e4d6 and d6d140f
I also split one commit into two, while removing the hash prefix from the version number.

@Mic92 Mic92 closed this in fe2e4d6 Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joelthompson @Mic92 @GrahamcOfBorg