Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notmuch: fix /bin/sh impurity in ./configure #37383

Merged
merged 1 commit into from Apr 9, 2018
Merged

notmuch: fix /bin/sh impurity in ./configure #37383

merged 1 commit into from Apr 9, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Mar 19, 2018 •
edited

Motivation for this change

/bin/sh in ./configure: https://hydra.nixos.org/build/71329862

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@hedning
Copy link
Contributor Author

hedning commented Mar 19, 2018

/bin/sh fixes should probably be backported to 18.03?

@dezgeg
Copy link
Contributor

dezgeg commented Mar 19, 2018

The build is fine under Nix 2.0. It's just that the 52.205.244.63 builder (listed here: https://hydra.nixos.org/build/71326198) needs Nix 2.0 instead of some really obsolete unstable Nix release.

@srhb
Copy link
Contributor

srhb commented Mar 24, 2018

@dezgeg Looks like a sensible change regardless though, doesn't it?

@oxij
Copy link
Member

oxij commented Mar 26, 2018 via email

@matthewbauer matthewbauer merged commit c472940 into NixOS:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hedning @dezgeg @srhb @oxij @matthewbauer @GrahamcOfBorg