release-lib: Filter supportedSystems with meta.platforms-style patterns
#37397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erns Instead of intersecting system strings, we filter with the sort of patterns used in `meta.platforms`. Indicating this change `forTheseSystems` has been renamed to `forMatchingSystems`, since the given list is now patterns to match, and not the systems themselves. [Just as with `meta.platforms`, systems strings are also supported for backwards compatibility.] This is more flexible, and makes the `forMatchingSystems` and packagePlatforms` cases more analogous.
GrahamcOfBorg
added
6.topic: emacs
6.topic: erlang
6.topic: fetch
6.topic: GNOME
Ericson2314
added
6.topic: portability
GrahamcOfBorg
added
6.topic: erlang
6.topic: fetch
6.topic: printing
6.topic: ruby
6.topic: steam
6.topic: vim
6.topic: xfce
Ericson2314
removed
6.topic: emacs
6.topic: erlang
6.topic: fetch
6.topic: GNOME
|
Wow github got really confused. This is merge; I expedited it because #34444 broke |
Ericson2314
added a commit
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Instead of intersecting system strings, we filter with the sort of patterns used in
meta.platforms.Indicating this change
forTheseSystemshas been renamed toforMatchingSystems, since the given list is now patterns to match, and not the systems themselves. [Just as withmeta.platforms, systemsstrings are also supported for backwards compatibility.]
This is more flexible, and makes the
forMatchingSystemsand packagePlatforms` cases more analogous.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)