Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse the order in which we print out the backtrace. #4876 #5094

Closed
wants to merge 1 commit into from
Closed

Reverse the order in which we print out the backtrace. #4876 #5094

wants to merge 1 commit into from
+9 −6

Conversation

headius
Copy link
Member

@headius headius commented Mar 19, 2018 •
edited
Loading

This implements the reverse backtrace introduced in Ruby 2.5. Notable missing bits:

  • This does not check for TTY to decide whether to reverse; it always reverses for the printing-out cases and always does not reverse for internal logging.
  • This provides no way to disable the reverse trace and go back to a forward trace.

See #4876.

@headius
Reverse the order in which we print out the backtrace. #4876

Verified

This commit was signed with the committer’s verified signature.
headius Charles Oliver Nutter
GPG key ID: 8E26FF248BC7AEAD
Verified
Learn about vigilant mode
b334ad5
@headius headius added this to the JRuby 9.2.0.0 milestone Mar 19, 2018
@headius headius mentioned this pull request Mar 19, 2018
Closed
75 tasks
@headius headius mentioned this pull request Mar 27, 2018
Closed
12 tasks
@headius headius modified the milestones: JRuby 9.2.0.0, JRuby 9.2.1.0 May 14, 2018
@headius
Copy link
Member Author

headius commented Oct 11, 2018

Low-priority item that can perhaps be done along with compat work in 9.3.

@headius headius modified the milestones: JRuby 9.2.1.0, JRuby 9.3.0.0 Oct 11, 2018
@headius
Copy link
Member Author

headius commented Apr 6, 2021

Dupe of #5510 and closed for the same reasons.

@headius headius closed this Apr 6, 2021
@headius headius modified the milestones: JRuby 9.3.0.0, Won't Fix Apr 6, 2021
@headius headius deleted the reverse_backtrace branch April 6, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ruby 2.5
Projects
None yet
Milestone
Won't Fix
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@headius