Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-drive-ocamlfuse and gapi-ocaml update #37385

Merged
merged 2 commits into from Mar 20, 2018
Merged

google-drive-ocamlfuse and gapi-ocaml update #37385

merged 2 commits into from Mar 20, 2018

Conversation

coreyoconnor
Copy link
Contributor

@coreyoconnor coreyoconnor commented Mar 19, 2018 •
edited

This required changing the build process for both packages. I noticed two things I'd like feedback on:

  1. While both libraries claimed to have migrated to "jbuilder" I still needed different commands for each.
  2. There are other ocaml packages using "opam" to build as well. I grabbed the "opam-install" command from one of these. Is there a standard script that should be referenced instead?
Motivation for this change
  1. update google-drive-ocamlfuse to 0.3.6
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@coreyoconnor
gapi-ocaml: 0.3.4 -> 0.3.6. Also change to use opam/jbuilder for build.
26fac59
@coreyoconnor
google-drive-ocamlfuse: 0.6.21 -> 0.6.25.
a140fe8 
Also change to use jbuilder for build per upstream instructions. In this case, the build needs to be
driven by jbuilder but opam still needs to be in PATH.
@Mic92
Copy link
Member

Mic92 commented Mar 19, 2018

@GrahamcOfBorg build google-drive-ocamlfuse

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: google-drive-ocamlfuse

No partial log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: google-drive-ocamlfuse

Partial log (click to expand)

_build/install/default/doc/google-drive-ocamlfuse/LICENSE => /nix/store/zajw37p2l69iqsjl10ks13n32llvdcdn-google-drive-ocamlfuse-0.6.25/doc/google-drive-ocamlfuse/LICENSE
post-installation fixup
moving /nix/store/zajw37p2l69iqsjl10ks13n32llvdcdn-google-drive-ocamlfuse-0.6.25/doc to /nix/store/zajw37p2l69iqsjl10ks13n32llvdcdn-google-drive-ocamlfuse-0.6.25/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/zajw37p2l69iqsjl10ks13n32llvdcdn-google-drive-ocamlfuse-0.6.25
shrinking /nix/store/zajw37p2l69iqsjl10ks13n32llvdcdn-google-drive-ocamlfuse-0.6.25/bin/google-drive-ocamlfuse
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zajw37p2l69iqsjl10ks13n32llvdcdn-google-drive-ocamlfuse-0.6.25/lib  /nix/store/zajw37p2l69iqsjl10ks13n32llvdcdn-google-drive-ocamlfuse-0.6.25/bin
patching script interpreter paths in /nix/store/zajw37p2l69iqsjl10ks13n32llvdcdn-google-drive-ocamlfuse-0.6.25
checking for references to /tmp/nix-build-google-drive-ocamlfuse-0.6.25.drv-0 in /nix/store/zajw37p2l69iqsjl10ks13n32llvdcdn-google-drive-ocamlfuse-0.6.25...
/nix/store/zajw37p2l69iqsjl10ks13n32llvdcdn-google-drive-ocamlfuse-0.6.25

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: google-drive-ocamlfuse

Partial log (click to expand)

_build/install/default/doc/google-drive-ocamlfuse/LICENSE => /nix/store/zs1dkdzl5r3n2p84px1pl65cwdcsjkcw-google-drive-ocamlfuse-0.6.25/doc/google-drive-ocamlfuse/LICENSE
post-installation fixup
moving /nix/store/zs1dkdzl5r3n2p84px1pl65cwdcsjkcw-google-drive-ocamlfuse-0.6.25/doc to /nix/store/zs1dkdzl5r3n2p84px1pl65cwdcsjkcw-google-drive-ocamlfuse-0.6.25/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/zs1dkdzl5r3n2p84px1pl65cwdcsjkcw-google-drive-ocamlfuse-0.6.25
shrinking /nix/store/zs1dkdzl5r3n2p84px1pl65cwdcsjkcw-google-drive-ocamlfuse-0.6.25/bin/google-drive-ocamlfuse
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zs1dkdzl5r3n2p84px1pl65cwdcsjkcw-google-drive-ocamlfuse-0.6.25/lib  /nix/store/zs1dkdzl5r3n2p84px1pl65cwdcsjkcw-google-drive-ocamlfuse-0.6.25/bin
patching script interpreter paths in /nix/store/zs1dkdzl5r3n2p84px1pl65cwdcsjkcw-google-drive-ocamlfuse-0.6.25
checking for references to /build in /nix/store/zs1dkdzl5r3n2p84px1pl65cwdcsjkcw-google-drive-ocamlfuse-0.6.25...
/nix/store/zs1dkdzl5r3n2p84px1pl65cwdcsjkcw-google-drive-ocamlfuse-0.6.25

@Mic92 Mic92 merged commit f71a636 into NixOS:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coreyoconnor @Mic92 @GrahamcOfBorg