Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RbConfig::CONFIG is missing entry for vendordir (and some related entries based off this) #1826

Closed
enebo opened this issue Jul 17, 2014 · 5 comments
Closed

RbConfig::CONFIG is missing entry for vendordir (and some related entries based off this) #1826

enebo opened this issue Jul 17, 2014 · 5 comments
Labels
core JRuby 1.7.x ruby 2.0-2.2
Milestone
JRuby 9.0.0.0

Comments

@enebo
Copy link
Member

enebo commented Jul 17, 2014

Current version of rubygems does not run without this (though they will be making a small workaround for us for the time being). Might as well audit some other keys in here since we seem to be missing lots of keys. The specific one causing problems is:

"vendordir"=>"/Users/enebo/Developer/.rvm/rubies/ruby-1.9.3-p547/lib/ruby/vendor_ruby"
@enebo enebo added this to the JRuby 1.7.14 milestone Jul 17, 2014
@drbrain
Copy link

drbrain commented Jul 17, 2014

See rubygems/rubygems#974

@enebo enebo modified the milestones: JRuby 1.7.14, JRuby 1.7.15 Aug 27, 2014
@headius
Copy link
Member

headius commented Nov 12, 2014

We do supply vendordir when it is configured via a flag or property. That was requested by some Linux package maintainers. But I'm not sure if we have to provide it. It would seem especially strange to provide it when we don't put it in LOAD_PATH, which is exactly why it's configurable.

@kares kares modified the milestones: JRuby 1.7.15, Won't Fix Mar 1, 2018
@kares
Copy link
Member

kares commented Mar 1, 2018

@enebo do you feel like this is still relevant or a 1.7 piece to be closed?

@kares
Copy link
Member

kares commented Mar 1, 2018

I mean still no RbConfig::CONFIG['vendordir'] but not one complains thus no problem :)

@headius
Copy link
Member

headius commented Mar 19, 2018

Example of enabling vendordir and friends using the Java properties we added.

$ jruby -J-Dvendor.dir.general=../jruby/lib -e "puts RbConfig::CONFIG['vendordir']"
../jruby/lib/ruby/stdlib/vendor_ruby

It seems to mess something up if you point it at an empty dir, though:

$ jruby -J-Dvendor.dir.general=/tmp -e "puts RbConfig::CONFIG['vendordir']"
NameError: uninitialized constant RbConfig
  const_missing at org/jruby/RubyModule.java:3411
         <main> at -e:1

We added the property because some JRuby distributors wanted a vendor dir, so I think we can call this one done a long time ago.

@headius headius closed this as completed Mar 19, 2018
@headius headius modified the milestones: Won't Fix, JRuby 9.0.0.0 Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core JRuby 1.7.x ruby 2.0-2.2
Projects
None yet
Milestone
JRuby 9.0.0.0
Development

No branches or pull requests
4 participants
@drbrain @headius @enebo @kares