Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

React warning while loading shot page #2216

Closed
pdehaan opened this issue Feb 24, 2017 · 4 comments
Closed

React warning while loading shot page #2216

pdehaan opened this issue Feb 24, 2017 · 4 comments
Assignees
Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product

Comments

@pdehaan
Copy link
Collaborator

pdehaan commented Feb 24, 2017

add-ons_manager

I'm seeing an error when I try and load the following shot page: https://pageshot.net/PNDTvTF1Q6jgffrZ/testpilot.firefox.com

Warning: React attempted to reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server:

   (client) ="Page-Shot-2017-2-23 Firefox Test Pilot
   (server) ="Page-Shot-2017-2-24 Firefox Test Pilot

@ckprice ckprice added the defect label Mar 1, 2017
@ckprice ckprice added this to the Next Tasks milestone Mar 1, 2017
@ghost ghost modified the milestones: Next Tasks, Blue Sky Jun 28, 2017
@ianb ianb added code Code quality issue, that does not have any outward effect on the product and removed defect labels Jan 10, 2018
@ianb ianb added the code quality Not a bug, targeted for fixing in 2018 label Jan 17, 2018
@chenba chenba self-assigned this Mar 14, 2018
chenba added a commit to chenba/screenshots that referenced this issue Mar 14, 2018
@chenba
Copy link
Collaborator

chenba commented Mar 19, 2018

Reopening this because setting the NODE_ICU_DATA env var is not working when deploying to dev.

@ianb
Copy link
Contributor

ianb commented Mar 19, 2018

In other places we use a pattern like this to find the location of a library:

node -e 'console.log(require("path").dirname(require.resolve("full-icu")))'

In the past I've found libraries aren't installed into entirely stable locations, and this helps.

@chenba
Copy link
Collaborator

chenba commented Mar 20, 2018

In this case, full-icu is not a js module to be required; the dir of a data file needs to supplied to node, either through env var or command line option.

I have verified that the ICU data file is in the latest docker image and in the expected path.

@chenba
Copy link
Collaborator

chenba commented Mar 21, 2018

Looks like the cause is likely a node version mismatch. It's 8.2.0 during the build, but the docker image is running 8.10.0. This resulted in the wrong version of the ICU data being in the docker image.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product
Projects
None yet
Development

No branches or pull requests

6 participants