Skip to content

lib: Make platform predicates greppable #37398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2018
Merged

lib: Make platform predicates greppable #37398

merged 1 commit into from
Mar 20, 2018
+55 −57

Conversation

Ericson2314
Copy link
Member

Motivation for this change

So everyone can find these definitions. Sorry I didn't get around to doing this sooner!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ericson2314 Ericson2314 requested a review from nbp as a code owner March 20, 2018 02:16
@Ericson2314 Ericson2314 added the 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform label Mar 20, 2018
@Ericson2314
lib: Make platform predicates greppable

Verified

This commit was signed with the committer’s verified signature.
pquentin Quentin Pradet
GPG key ID: E328ACB1EC7E57C2
Verified
Learn about vigilant mode
88c04a8
@Ericson2314 Ericson2314 changed the base branch from master to staging March 20, 2018 02:31
@Ericson2314 Ericson2314 changed the base branch from staging to master March 20, 2018 02:31
@GrahamcOfBorg GrahamcOfBorg added 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion 6.topic: python 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion 6.topic: python 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 20, 2018
@GrahamcOfBorg GrahamcOfBorg added the 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux label Mar 20, 2018
@Ericson2314 Ericson2314 merged commit 5432107 into NixOS:master Mar 20, 2018
@Ericson2314 Ericson2314 deleted the greppable branch March 20, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy

@dezgeg dezgeg

@dtzWill dtzWill

@edolstra edolstra

@nbp nbp

Assignees
No one assigned
Labels
6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg