Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Make platform predicates greppable #37398

Merged
merged 1 commit into from Mar 20, 2018
Merged

lib: Make platform predicates greppable #37398

merged 1 commit into from Mar 20, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

So everyone can find these definitions. Sorry I didn't get around to doing this sooner!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 requested a review from nbp as a code owner March 20, 2018 02:16
@Ericson2314 Ericson2314 added the 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform label Mar 20, 2018
@Ericson2314 Ericson2314 changed the base branch from master to staging March 20, 2018 02:31
@Ericson2314 Ericson2314 changed the base branch from staging to master March 20, 2018 02:31
@Ericson2314 Ericson2314 merged commit 5432107 into NixOS:master Mar 20, 2018
@Ericson2314 Ericson2314 deleted the greppable branch March 20, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy Awaiting requested review from shlevy

@dezgeg dezgeg Awaiting requested review from dezgeg

@dtzWill dtzWill Awaiting requested review from dtzWill

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg