grepcidr: Init at 2.0 #38685
Merged
grepcidr: Init at 2.0 #38685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
requested changes
Apr 10, 2018
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| cp grepcidr $out/bin/ |
There was a problem hiding this comment.
Please use the default installPhase. You'll probably have to set something like
installFlags = [ "PREFIX=$out" ];
There was a problem hiding this comment.
checked the makefile. installFlags = [ "PREFIX=$(out)" ]; should work.
| version = "2.0"; | ||
|
|
||
| src = fetchurl { | ||
| url = "http://www.pc-tools.net/files/unix/grepcidr-${version}.tar.gz"; |
There was a problem hiding this comment.
grepcidr-${version} can be replaced by ${name}
|
@GrahamcOfBorg build grepcidr |
|
Success on aarch64-linux (full log) Attempted: grepcidr Partial log (click to expand)
|
dotlambda
reviewed
Apr 19, 2018
| description = "Filter IPv4 and IPv6 addresses matching CIDR patterns"; | ||
| homepage = http://www.pc-tools.net/unix/grepcidr/; | ||
| license = licenses.gpl3; | ||
| platforms = platforms.unix; |
There was a problem hiding this comment.
@dotlambda yes, tested and working with:
- system:
"x86_64-darwin" - host os:
Darwin 16.7.0, macOS 10.12.6 - multi-user?:
yes - sandbox:
no
dotlambda
approved these changes
Apr 19, 2018
|
Success on x86_64-linux (full log) Attempted: grepcidr Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
grepcidr was not available on NixOS: http://www.pc-tools.net/unix/grepcidr/
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)