Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librsvg: 2.42.2 → 2.42.3 #38680

Merged
merged 3 commits into from Apr 12, 2018
Merged

librsvg: 2.42.2 → 2.42.3 #38680

merged 3 commits into from Apr 12, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 10, 2018

Motivation for this change

librsvg 2.42.3 needs development version of libcairo but it should be fine, Arch is using it too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar requested a review from FRidh as a code owner April 10, 2018 12:43
dotlambda
dotlambda reviewed Apr 10, 2018
View reviewed changes
pkgs/development/python-modules/pycairo/default.nix Outdated
# We need to create the pkgconfig file but it cannot be installed as a wheel since wheels
# are supposed to be relocatable and do not support --prefix option
buildPhase = ''
python setup.py build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use ${python.interpreter} setup.py build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: cairo, librsvg

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/i0i8a2agnm77dz5z91q4k2hww74i9b8b-vala-0.38.4/lib  /nix/store/i0i8a2agnm77dz5z91q4k2hww74i9b8b-vala-0.38.4/bin
patching script interpreter paths in /nix/store/i0i8a2agnm77dz5z91q4k2hww74i9b8b-vala-0.38.4
/nix/store/i0i8a2agnm77dz5z91q4k2hww74i9b8b-vala-0.38.4/bin/vala-gen-introspect-0.38: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /tmp/nix-build-vala-0.38.4.drv-0 in /nix/store/i0i8a2agnm77dz5z91q4k2hww74i9b8b-vala-0.38.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/jn0435by7whz81pxyzs8lny6b8cri0by-vala-0.38.4-devdoc
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/jn0435by7whz81pxyzs8lny6b8cri0by-vala-0.38.4-devdoc
checking for references to /tmp/nix-build-vala-0.38.4.drv-0 in /nix/store/jn0435by7whz81pxyzs8lny6b8cri0by-vala-0.38.4-devdoc...
cannot build derivation ‘/nix/store/yb0rh713vi08wcsaxf5w8h3sycxwqv4g-librsvg-2.42.3.drv’: 2 dependencies couldn't be built
error: build of ‘/nix/store/yb0rh713vi08wcsaxf5w8h3sycxwqv4g-librsvg-2.42.3.drv’ failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: cairo, librsvg

Partial log (click to expand)

cannot build derivation '/nix/store/yvr97h87ipjq624d2qcyjify7ylr48wl-mesa-8.0.5.drv': 27 dependencies couldn't be built
cannot build derivation '/nix/store/cvd9rq69liv8h4hxcl4d0cph8hx6nig0-gobject-introspection-1.56.0.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/1ivdxk4q9ik925x0mcqk3rjnigk1mz0j-libdevil-1.7.8.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/m7fb64gn41jpyasbw1c5n63lvldq2lhq-gdk-pixbuf-2.36.7.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/7rlh2dmxrzy6rl06v9lx5qz9ljx8c4pv-pango-1.40.14.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/p7c0nbv0qs3dqjanv0npjwwvjffwdfb0-graphviz-2.40.1.drv': 21 dependencies couldn't be built
cannot build derivation '/nix/store/b2ws0qlj6ji2mh6mh6qp8b0ldzrzfr93-libgsf-1.14.42.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/zc2pbf7hh4jzp12fqlirh7m83gabbmfa-vala-0.38.4.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/qgkh5a12jbnx8bkh46cd3ja5qqrz8haz-librsvg-2.42.3.drv': 18 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/8paafkkrcrzyqk7dd280q9hvq52q6bin-cairo-1.15.10.drv', '/nix/store/qgkh5a12jbnx8bkh46cd3ja5qqrz8haz-librsvg-2.42.3.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: cairo, librsvg

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/i0i8a2agnm77dz5z91q4k2hww74i9b8b-vala-0.38.4/lib  /nix/store/i0i8a2agnm77dz5z91q4k2hww74i9b8b-vala-0.38.4/bin
patching script interpreter paths in /nix/store/i0i8a2agnm77dz5z91q4k2hww74i9b8b-vala-0.38.4
/nix/store/i0i8a2agnm77dz5z91q4k2hww74i9b8b-vala-0.38.4/bin/vala-gen-introspect-0.38: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/i0i8a2agnm77dz5z91q4k2hww74i9b8b-vala-0.38.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/jn0435by7whz81pxyzs8lny6b8cri0by-vala-0.38.4-devdoc
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/jn0435by7whz81pxyzs8lny6b8cri0by-vala-0.38.4-devdoc
checking for references to /build in /nix/store/jn0435by7whz81pxyzs8lny6b8cri0by-vala-0.38.4-devdoc...
cannot build derivation '/nix/store/r1g31504vc5gmig3yl44m8r4d1xfa5c6-librsvg-2.42.3.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/r1g31504vc5gmig3yl44m8r4d1xfa5c6-librsvg-2.42.3.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: cairo, librsvg

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/zsslvhg2kmq2wdmibm2ph476rsypzjqq-vala-0.38.4/lib  /nix/store/zsslvhg2kmq2wdmibm2ph476rsypzjqq-vala-0.38.4/bin
patching script interpreter paths in /nix/store/zsslvhg2kmq2wdmibm2ph476rsypzjqq-vala-0.38.4
/nix/store/zsslvhg2kmq2wdmibm2ph476rsypzjqq-vala-0.38.4/bin/vala-gen-introspect-0.38: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/zsslvhg2kmq2wdmibm2ph476rsypzjqq-vala-0.38.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/w77g8xrkim2r3kxdri4jzvy9dz3kk33v-vala-0.38.4-devdoc
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/w77g8xrkim2r3kxdri4jzvy9dz3kk33v-vala-0.38.4-devdoc
checking for references to /build in /nix/store/w77g8xrkim2r3kxdri4jzvy9dz3kk33v-vala-0.38.4-devdoc...
cannot build derivation '/nix/store/sagqbkgxg2lc17495bk00gj755l0ipm2-librsvg-2.42.3.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/sagqbkgxg2lc17495bk00gj755l0ipm2-librsvg-2.42.3.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: cairo, librsvg

Partial log (click to expand)

1 out of 1 hunk ignored -- saving rejects to file src/libstd/sys/windows/thread.rs.rej
patching file src/libstd/sys_common/thread_info.rs
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file src/libstd/sys_common/thread_info.rs.rej
builder for '/nix/store/pp8w3yrbpj32qcvj9il97pjpvf0a2p74-rustc-1.25.0.drv' failed with exit code 1
cannot build derivation '/nix/store/baj4bmcxz0ghjk7f0cizm4s3symcsp2r-cargo-0.26.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sagqbkgxg2lc17495bk00gj755l0ipm2-librsvg-2.42.3.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/sagqbkgxg2lc17495bk00gj755l0ipm2-librsvg-2.42.3.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: cairo, librsvg

Partial log (click to expand)

cannot build derivation '/nix/store/yvr97h87ipjq624d2qcyjify7ylr48wl-mesa-8.0.5.drv': 27 dependencies couldn't be built
cannot build derivation '/nix/store/cvd9rq69liv8h4hxcl4d0cph8hx6nig0-gobject-introspection-1.56.0.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/1ivdxk4q9ik925x0mcqk3rjnigk1mz0j-libdevil-1.7.8.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/m7fb64gn41jpyasbw1c5n63lvldq2lhq-gdk-pixbuf-2.36.7.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/7rlh2dmxrzy6rl06v9lx5qz9ljx8c4pv-pango-1.40.14.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/p7c0nbv0qs3dqjanv0npjwwvjffwdfb0-graphviz-2.40.1.drv': 21 dependencies couldn't be built
cannot build derivation '/nix/store/b2ws0qlj6ji2mh6mh6qp8b0ldzrzfr93-libgsf-1.14.42.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/zc2pbf7hh4jzp12fqlirh7m83gabbmfa-vala-0.38.4.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/qgkh5a12jbnx8bkh46cd3ja5qqrz8haz-librsvg-2.42.3.drv': 18 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/8paafkkrcrzyqk7dd280q9hvq52q6bin-cairo-1.15.10.drv', '/nix/store/qgkh5a12jbnx8bkh46cd3ja5qqrz8haz-librsvg-2.42.3.drv' failed

@jtojnar jtojnar mentioned this pull request Apr 10, 2018
Closed
@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 12, 2018

Tested with font-manager. Emoji are now rendered in colour 🎉

@jtojnar jtojnar merged commit 8bf523e into NixOS:staging Apr 12, 2018
@jtojnar jtojnar deleted the librsvg-2.42.3 branch April 19, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @GrahamcOfBorg @dotlambda