nixos/acme: Service should not fail when no renewal is necessary #38689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The acme service script re-uses the exit code of the simp_le program which is 0 on successful change, 1 if no renewal is necessary, and 2 on error. This causes the service to end up in failed status when no renewal is necessary, which is wrong. With this patch the exit code from the acme script is 0 when simp_le returns 1 and otherwise the same as returned by simp_le. The postStop script still uses the unchanged exit code from simp_le to determine wether to run the postRun hook or not.
|
I haven't had time to write a PR to do this, but this is probably doable using For more info on the environment variables, see here. |
|
Thanks, I see now that the service already specifies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The acme service script re-uses the exit code of the simp_le program which is 0 on successful change, 1 if no renewal is necessary, and 2 on error. This causes the service to end up in failed status when no renewal is necessary, which is wrong.
With this patch the exit code from the acme script is 0 when simp_le returns 1 and otherwise the same as returned by simp_le.
Things done
Tested in QA environment at work.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)