Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purple-discord: init at 2018-04-10 #38686

Merged
merged 2 commits into from Apr 15, 2018
Merged

purple-discord: init at 2018-04-10 #38686

merged 2 commits into from Apr 15, 2018

Conversation

S-NA
Copy link
Contributor

@S-NA S-NA commented Apr 10, 2018 •
edited

Motivation for this change

Adds new pidgin plugin that brings Discord support. In addition, add myself to the maintainers list.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar mind reviewing this again? Sorry about the new pull request, did not know GitHub would close it, when I forced a push to squash my commits. Also thank you for telling me about PKG_CONFIG_${package}_${variable} it is awesome.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 11, 2018

@GrahamcOfBorg build pidgin-discord

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pidgin-discord

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pidgin-discord

Partial log (click to expand)

rm po/it.mo po/es.mo po/ru.mo
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10
shrinking /nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10/lib/pidgin/libdiscord.so
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10/lib
patching script interpreter paths in /nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10
checking for references to /build in /nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10...
/nix/store/5an8bkg4r9laa9bw40jw9ccadz4zbw1x-pidgin-discord-unstable-2018-04-10

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pidgin-discord

Partial log (click to expand)

rm po/it.mo po/es.mo po/ru.mo
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nypphn2xgd2himyvxbwsnjrzmx7z4gwp-pidgin-discord-unstable-2018-04-10
shrinking /nix/store/nypphn2xgd2himyvxbwsnjrzmx7z4gwp-pidgin-discord-unstable-2018-04-10/lib/pidgin/libdiscord.so
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nypphn2xgd2himyvxbwsnjrzmx7z4gwp-pidgin-discord-unstable-2018-04-10/lib
patching script interpreter paths in /nix/store/nypphn2xgd2himyvxbwsnjrzmx7z4gwp-pidgin-discord-unstable-2018-04-10
checking for references to /build in /nix/store/nypphn2xgd2himyvxbwsnjrzmx7z4gwp-pidgin-discord-unstable-2018-04-10...
/nix/store/nypphn2xgd2himyvxbwsnjrzmx7z4gwp-pidgin-discord-unstable-2018-04-10

jtojnar
jtojnar requested changes Apr 12, 2018
View reviewed changes
pkgs/applications/networking/instant-messengers/pidgin-plugins/pidgin-discord/default.nix Outdated
"DESTDIR=$(out)"
];

PKG_CONFIG_PURPLE_PLUGINDIR = "/lib/pidgin";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be lib/purple-2, see #38311.

pkgs/top-level/all-packages.nix Outdated
@@ -17278,6 +17278,8 @@ with pkgs;
plugins = [];
};

pidgin-discord = callPackage ../applications/networking/instant-messengers/pidgin-plugins/pidgin-discord { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you naming it pidgin-discord when the repo is called purple-discord?

@S-NA
Copy link
Contributor Author

S-NA commented Apr 15, 2018

@jtojnar changes applied, sorry for the oversight.

@S-NA S-NA changed the title pidgin-discord: init at 2018-04-10 purple-discord: init at 2018-04-10 Apr 15, 2018
@jtojnar jtojnar merged commit 92f0d31 into NixOS:master Apr 15, 2018
@S-NA S-NA deleted the pidgin-discord branch August 17, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@S-NA @jtojnar @GrahamcOfBorg