Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't override version from SpaceDock with version from version file #2405

Closed
HebaruSan opened this issue Apr 10, 2018 · 0 comments
Closed

Can't override version from SpaceDock with version from version file #2405

HebaruSan opened this issue Apr 10, 2018 · 0 comments
Assignees
@HebaruSan
Labels
Netkan Issues affecting the netkan data

Comments

@HebaruSan
Copy link
Member

HebaruSan commented Apr 10, 2018 •
edited
Loading

Background

CKAN Version:
HEAD (post-1.24.0)

KSP Version:
1.4.2

Operating System:
Win7

Have you made any manual changes to your GameData folder (i.e., not via CKAN)?
No

Problem

What steps did you take in CKAN?

See KSP-CKAN/NetKAN#6471; specified the correct version file for the copy of DynamicBatteryStorage bundled in NearFutureElectrical.

What did you expect to happen?

version should come out as 1.3.0.0, because that's what's in that file.

What happened instead?

version is 0.10.0 instead, because that's what is set on SpaceDock. This is done on purpose:

CKAN/Netkan/Transformers/AvcTransformer.cs

Lines 154 to 160 in a495f43

if (avc.version != null)
{
// In practice, the version specified in .version files tends to be unreliable, with authors
// forgetting to update it when new versions are released. Therefore if we have a version
// specified from another source such as SpaceDock, curse or a GitHub tag, don't overwrite it.
json.SafeAdd("version", avc.version.ToString());
}

That's a reasonable rationale, but it makes it impossible to handle this situation correctly because the version on SpaceDock is not the version for the bundled mod. It would be nice if there was a way to override this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HebaruSan HebaruSan

Labels
Netkan Issues affecting the netkan data
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HebaruSan @politas