Skip to content

Commit

Permalink
Fixes #5084.
Browse files Browse the repository at this point in the history
First attempt at using newest install4j.  This version we got an updated OSS
license for and it works with Java 9+.  After install4j updated our old file
nearly everything works except that media type changed to 'windows' from
'win32'.  This also changed the platform variable name so that had to be
tweaked.  I did a mock release and put ONLY java 9 on a windows machine and it
installs.  Huzzah
enebo committed Apr 10, 2018
1 parent 232047b commit c5ddf24
Showing 3 changed files with 930 additions and 113 deletions.
2 changes: 1 addition & 1 deletion default.build.properties
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ release.dir=release
test.results.dir=${build.dir}/test-results
jruby.launch.memory=1024M
rake.args=
install4j.executable=/Applications/install4j 4/bin/install4jc
install4j.executable=/Applications/install4j7/bin/install4jc

# Ruby versions
version.ruby=2.3.3
1,039 changes: 928 additions & 111 deletions install/jruby.install4j

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion rakelib/installer.rake
Original file line number Diff line number Diff line change
@@ -91,7 +91,7 @@ task :windows_installer => :init_release do
if File.executable?(INSTALL4J_EXECUTABLE)
root_dir = Dir.pwd
Dir.chdir(unpacked_dir) do
sh %Q^"#{INSTALL4J_EXECUTABLE}" -m win32 -D jruby.dist.location=#{root_dir},jruby.location=#{unpacked_dir},ruby.version=#{VERSION_RUBY},jruby.version=#{version},ruby.patchlevel=0,ruby.buildplatform=i386-mingw32 #{INSTALL4J_CONFIG_FILE}^ do |ok, result|
sh %Q^"#{INSTALL4J_EXECUTABLE}" -m windows -D jruby.dist.location=#{root_dir},jruby.location=#{unpacked_dir},ruby.version=#{VERSION_RUBY},jruby.version=#{version},ruby.patchlevel=0,ruby.buildplatform=i386-mingw32 #{INSTALL4J_CONFIG_FILE}^ do |ok, result|
$stderr.puts "** Something went wrong: #{result}" unless ok
end
mv Dir[File.join(root_dir, 'install', '*.exe')], File.join(root_dir, RELEASE_DIR)

0 comments on commit c5ddf24

Please sign in to comment.