Copy non-standard style and JS DOM nodes from the generated docs for richer docs #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
changed the title
grahamc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on making the docs a bit nicer. One thing I have done is replaced the .gif's with .svg's: NixOS/nixpkgs#37881 This worked nicely, but because the CSS is completely replaced on deploy to the website, the images break down (see my first comment.)
The simple fix for that is send a PR here adding those six lines to the global CSS, but a more flexible option is allowing some CSS to be carried over from the generated HTML in to the bootstrapified HTML.
I chose this option, though, because a follow-up PR is adding syntax highlighting of our Nix code to the docs. This will also require custom CSS, and a bit of javascript. It seems nice for the
nix-buildversion to have the highlighting, so I'm wary of duplicating the logic in both places ... thus this solution.This PR, combined with my SVG PR, combined with my syntax highlighting branch come together to look like this: