Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.libais: 0.16 -> 0.17 #37876

Merged
merged 1 commit into from Apr 11, 2018
Merged

pythonPackages.libais: 0.16 -> 0.17 #37876

merged 1 commit into from Apr 11, 2018

Conversation

lsix
Copy link
Member

@lsix lsix commented Mar 26, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lsix lsix requested a review from FRidh as a code owner March 26, 2018 16:32
dotlambda
dotlambda reviewed Mar 30, 2018
View reviewed changes
pkgs/development/python-modules/libais/default.nix Outdated
@@ -1,14 +1,14 @@
{ stdenv, buildPythonPackage, fetchurl,
{ stdenv, buildPythonPackage, fetchPypi,
six, pytest, pytestrunner, pytestcov, coverage
}:
buildPythonPackage rec {
pname = "libais";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this line.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.libais python3.pkgs.libais

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.libais, python3.pkgs.libais

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/55g0gw38qvdlf56p9phnpabwkwi7f2mp-python3.6-libais-0.17
shrinking /nix/store/55g0gw38qvdlf56p9phnpabwkwi7f2mp-python3.6-libais-0.17/lib/python3.6/site-packages/_ais.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/55g0gw38qvdlf56p9phnpabwkwi7f2mp-python3.6-libais-0.17/lib  /nix/store/55g0gw38qvdlf56p9phnpabwkwi7f2mp-python3.6-libais-0.17/bin
patching script interpreter paths in /nix/store/55g0gw38qvdlf56p9phnpabwkwi7f2mp-python3.6-libais-0.17
checking for references to /tmp/nix-build-python3.6-libais-0.17.drv-0 in /nix/store/55g0gw38qvdlf56p9phnpabwkwi7f2mp-python3.6-libais-0.17...
wrapping `/nix/store/55g0gw38qvdlf56p9phnpabwkwi7f2mp-python3.6-libais-0.17/bin/aisdecode'...
wrapping `/nix/store/55g0gw38qvdlf56p9phnpabwkwi7f2mp-python3.6-libais-0.17/bin/libais_stats'...
/nix/store/6f0baj1wac66ns2hjlnrxkfm6kpgsw60-python2.7-libais-0.17
/nix/store/55g0gw38qvdlf56p9phnpabwkwi7f2mp-python3.6-libais-0.17

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.libais, python3.pkgs.libais

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/lj3bzlc1j56247sbm69h0l1ik1h9ksqn-python3.6-libais-0.17
shrinking /nix/store/lj3bzlc1j56247sbm69h0l1ik1h9ksqn-python3.6-libais-0.17/lib/python3.6/site-packages/_ais.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/lj3bzlc1j56247sbm69h0l1ik1h9ksqn-python3.6-libais-0.17/lib  /nix/store/lj3bzlc1j56247sbm69h0l1ik1h9ksqn-python3.6-libais-0.17/bin
patching script interpreter paths in /nix/store/lj3bzlc1j56247sbm69h0l1ik1h9ksqn-python3.6-libais-0.17
checking for references to /build in /nix/store/lj3bzlc1j56247sbm69h0l1ik1h9ksqn-python3.6-libais-0.17...
wrapping `/nix/store/lj3bzlc1j56247sbm69h0l1ik1h9ksqn-python3.6-libais-0.17/bin/libais_stats'...
wrapping `/nix/store/lj3bzlc1j56247sbm69h0l1ik1h9ksqn-python3.6-libais-0.17/bin/aisdecode'...
/nix/store/s8gb6khpaqygbxf7paf4mrha5dk4r8cv-python2.7-libais-0.17
/nix/store/lj3bzlc1j56247sbm69h0l1ik1h9ksqn-python3.6-libais-0.17

dotlambda
dotlambda reviewed Mar 30, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the expression should be modernized a little more: buildInputs needs to be changed to checkInputs and checks should best be enabled.

@lsix
Copy link
Member Author

lsix commented Apr 11, 2018

@dotlambda sorry for such long delay. I have updated the PR to match your comments.

@dotlambda
Copy link
Member

@GrahamcOfBorg eval
@GrahamcOfBorg build python2.pkgs.libais python3.pkgs.libais

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.libais, python3.pkgs.libais

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/48px8g36621kyb011ca4kxsymncprknh-python3.6-libais-0.17
shrinking /nix/store/48px8g36621kyb011ca4kxsymncprknh-python3.6-libais-0.17/lib/python3.6/site-packages/_ais.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/48px8g36621kyb011ca4kxsymncprknh-python3.6-libais-0.17/lib  /nix/store/48px8g36621kyb011ca4kxsymncprknh-python3.6-libais-0.17/bin
patching script interpreter paths in /nix/store/48px8g36621kyb011ca4kxsymncprknh-python3.6-libais-0.17
checking for references to /build in /nix/store/48px8g36621kyb011ca4kxsymncprknh-python3.6-libais-0.17...
wrapping `/nix/store/48px8g36621kyb011ca4kxsymncprknh-python3.6-libais-0.17/bin/libais_stats'...
wrapping `/nix/store/48px8g36621kyb011ca4kxsymncprknh-python3.6-libais-0.17/bin/aisdecode'...
/nix/store/8vwf6vxlmnhsdcvhnl1dkzm8jyg3qf1b-python2.7-libais-0.17
/nix/store/48px8g36621kyb011ca4kxsymncprknh-python3.6-libais-0.17

@dotlambda
Copy link
Member

Note that I have opened schwehr/libais#180.

@dotlambda dotlambda merged commit 21943e0 into NixOS:master Apr 11, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.libais, python3.pkgs.libais

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/6igq6a8xgcsvpg63wfccbi5jn5pdy3px-python3.6-libais-0.17
shrinking /nix/store/6igq6a8xgcsvpg63wfccbi5jn5pdy3px-python3.6-libais-0.17/lib/python3.6/site-packages/_ais.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6igq6a8xgcsvpg63wfccbi5jn5pdy3px-python3.6-libais-0.17/lib  /nix/store/6igq6a8xgcsvpg63wfccbi5jn5pdy3px-python3.6-libais-0.17/bin
patching script interpreter paths in /nix/store/6igq6a8xgcsvpg63wfccbi5jn5pdy3px-python3.6-libais-0.17
checking for references to /tmp/nix-build-python3.6-libais-0.17.drv-0 in /nix/store/6igq6a8xgcsvpg63wfccbi5jn5pdy3px-python3.6-libais-0.17...
wrapping `/nix/store/6igq6a8xgcsvpg63wfccbi5jn5pdy3px-python3.6-libais-0.17/bin/aisdecode'...
wrapping `/nix/store/6igq6a8xgcsvpg63wfccbi5jn5pdy3px-python3.6-libais-0.17/bin/libais_stats'...
/nix/store/pvkh2nj9p39r6g1a0xg27ckgwgcgszgn-python2.7-libais-0.17
/nix/store/6igq6a8xgcsvpg63wfccbi5jn5pdy3px-python3.6-libais-0.17

lsix added a commit that referenced this pull request Apr 12, 2018
@lsix
pythonPackages.libais: 0.16 -> 0.17 (#37876)
82233e0 
Signed-off-by: Lancelot SIX <lsix@lancelotsix.com>
@lsix lsix deleted the update_python_libais branch August 22, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsix @dotlambda @GrahamcOfBorg