Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk10: minor cleanups #37870

Merged
merged 1 commit into from Mar 28, 2018
Merged

openjdk10: minor cleanups #37870

merged 1 commit into from Mar 28, 2018

Conversation

jerith666
Copy link
Contributor

  • with only one source bundle (per JEP-296), we can use src instead of
    srcs, and avoid the need to cd in prePatch

  • fetch sources from jdk10u instead of jdk10, to make it easier to
    grab updates when they start coming.

  • removed commented-out code that became irrelevant in the 8 -> 9
    transition (*.pf files, infinality font rendering)

  • create jdk10, jre10, and jre10_headless attributes in
    all-packages.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

* with only one source bundle (per JEP-296), we can use src instead of
  srcs, and avoid the need to cd in prePatch

* fetch sources from jdk10u instead of jdk10, to make it easier to
  grab updates when they start coming.

* removed commented-out code that became irrelevant in the 8 -> 9
  transition (*.pf files, infinality font rendering)

* create jdk10, jre10, and jre10_headless attributes in
  all-packages.nix
@Mic92
Copy link
Member

Mic92 commented Mar 26, 2018

cc @volth

@fpletz fpletz merged commit 8c76754 into NixOS:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants