Generators default values #37874
Merged
Generators default values #37874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* properly escape strings * remove one check for booleans * improve error message
aszlig
approved these changes
Mar 28, 2018
lib/generators.nix
Outdated
| "${t} not supported: ${toPretty {} v}"); | ||
| in if isInt v then toString v | ||
| # we default to not quoting strings | ||
| else if isString v then ''${v}'' |
There was a problem hiding this comment.
If v is already a string, why antiquote it?
There was a problem hiding this comment.
This was a leftover, because I first thought quoting the string might be a good idea.
doc/functions.xml
Outdated
| @@ -221,16 +221,68 @@ | |||
|
|
|||
| <para> | |||
| All generators follow a similar call interface: <code>generatorName | |||
| configFunctions data</code>, where <literal>configFunctions</literal> is a | |||
| set of user-defined functions that format variable parts of the content. | |||
| { configFunctions } data</code>, where <literal>configFunctions</literal> is | |||
There was a problem hiding this comment.
Really? As I can see this doesn't seem to be the case, it's still like toINI { mkSectionName = ... } and not toINI { configFunctions.mkSectionName = ... }, did I miss something? And if yes, then it's a backwards-incompatibility and should have a release notes entry.
There was a problem hiding this comment.
Ah, is that confusing? I added the {} to make it easier to see that it’s an attrset, which is of course not the formally correct way. If it tripped you up, I think I’ll revert that.
So far, `mkValueString` defaulted to `toString`, which is a bad match for most configuration file formats, especially because how booleans are formatted. This also improves error messages for unsupported types. Add a test to codify the formatting.
An example of overriding the `toINI` generator is added, hopefully clarifying the expressiveness of generators.
Profpatsch
force-pushed
the
generators-default-values
branch
from
d5e9343
to
2ef7297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better default values & documentation; see commit messages.
cc @aszlig