Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudfoundry-cli: fix build #37872

Merged
merged 1 commit into from Mar 28, 2018
Merged

cloudfoundry-cli: fix build #37872

merged 1 commit into from Mar 28, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Mar 26, 2018

Motivation for this change

Fix build. The package doesn't build because of go version mismatch - package is built using 1.9 (the default of buildGoPackage), while remove-references-to of the custom installPhase tries to strip references to go which is 1.10. It fails to build on 18.03 as well so might be worth backporting.

Out of curiosity - is there a reason for this mismatch between buildGoPackage and the default go version? (I don't know much about go).

Closes #37841.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cloudfoundry-cli

Partial log (click to expand)

code.cloudfoundry.org/cli
installing
post-installation fixup
sed: couldn't open temporary file /bin/sedVjSR8C: Permission denied
shrinking RPATHs of ELF executables and libraries in /nix/store/25g31himm3pjj634rl1fqqpx61x3yls3-cloudfoundry-cli-6.32.0
shrinking /nix/store/25g31himm3pjj634rl1fqqpx61x3yls3-cloudfoundry-cli-6.32.0/bin/cf
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/25g31himm3pjj634rl1fqqpx61x3yls3-cloudfoundry-cli-6.32.0/bin
patching script interpreter paths in /nix/store/25g31himm3pjj634rl1fqqpx61x3yls3-cloudfoundry-cli-6.32.0
checking for references to /build in /nix/store/25g31himm3pjj634rl1fqqpx61x3yls3-cloudfoundry-cli-6.32.0...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cloudfoundry-cli

Partial log (click to expand)

installing
post-installation fixup
sed: couldn't open temporary file /bin/sedlylIY4: Permission denied
shrinking RPATHs of ELF executables and libraries in /nix/store/5m6zlw7j27z4zwd67nckq0y4g3fkjj4i-cloudfoundry-cli-6.32.0
shrinking /nix/store/5m6zlw7j27z4zwd67nckq0y4g3fkjj4i-cloudfoundry-cli-6.32.0/bin/cf
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5m6zlw7j27z4zwd67nckq0y4g3fkjj4i-cloudfoundry-cli-6.32.0/bin
patching script interpreter paths in /nix/store/5m6zlw7j27z4zwd67nckq0y4g3fkjj4i-cloudfoundry-cli-6.32.0
checking for references to /build in /nix/store/5m6zlw7j27z4zwd67nckq0y4g3fkjj4i-cloudfoundry-cli-6.32.0...
/nix/store/5m6zlw7j27z4zwd67nckq0y4g3fkjj4i-cloudfoundry-cli-6.32.0

@xeji
Copy link
Contributor

xeji commented Mar 27, 2018

/cc ZHF #36453

@fpletz fpletz added this to the 18.03 milestone Mar 28, 2018
@fpletz fpletz merged commit 3cc0342 into NixOS:master Mar 28, 2018
@pbogdan pbogdan deleted the cf-cli-fix-build branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbogdan @GrahamcOfBorg @xeji @fpletz