Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell.compiler.ghc8{22,41}: Fix abi-depends non-determinism. #37867

Merged
merged 1 commit into from Mar 26, 2018

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Mar 26, 2018

See haskell/cabal#4728 for symptoms,
https://phabricator.haskell.org/D4159 for the base of the fix.

@shlevy
Copy link
Member Author

shlevy commented Mar 26, 2018

@GrahamcOfBorg build haskell.compilers.ghc822 haskell.compilers.ghc841

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: haskell.compilers.ghc822, haskell.compilers.ghc841

Partial log (click to expand)

Cannot nix-instantiate `haskell.compilers.ghc822' because:
�[31;1merror:�[0m attribute 'compilers' in selection path 'haskell.compilers.ghc822' not found

Cannot nix-instantiate `haskell.compilers.ghc841' because:
�[31;1merror:�[0m attribute 'compilers' in selection path 'haskell.compilers.ghc841' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compilers.ghc822, haskell.compilers.ghc841

Partial log (click to expand)

Cannot nix-instantiate `haskell.compilers.ghc822' because:
�[31;1merror:�[0m attribute 'compilers' in selection path 'haskell.compilers.ghc822' not found

Cannot nix-instantiate `haskell.compilers.ghc841' because:
�[31;1merror:�[0m attribute 'compilers' in selection path 'haskell.compilers.ghc841' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: haskell.compilers.ghc822, haskell.compilers.ghc841

Partial log (click to expand)

Cannot nix-instantiate `haskell.compilers.ghc822' because:
�[31;1merror:�[0m attribute 'compilers' in selection path 'haskell.compilers.ghc822' not found

Cannot nix-instantiate `haskell.compilers.ghc841' because:
�[31;1merror:�[0m attribute 'compilers' in selection path 'haskell.compilers.ghc841' not found

@shlevy
Copy link
Member Author

shlevy commented Mar 26, 2018

@GrahamcOfBorg build haskell.compiler.ghc822 haskell.compiler.ghc841

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskell.compiler.ghc822, haskell.compiler.ghc841

Partial log (click to expand)

wrong ELF type
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/1v189wf6zyrvhj7wljkha3nn2z4lxwvq-ghc-8.4.1-doc
/nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/1v189wf6zyrvhj7wljkha3nn2z4lxwvq-ghc-8.4.1-doc
/nix/store/1v189wf6zyrvhj7wljkha3nn2z4lxwvq-ghc-8.4.1-doc/share/doc/ghc/html/libraries/gen_contents_index: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/1v189wf6zyrvhj7wljkha3nn2z4lxwvq-ghc-8.4.1-doc...
/nix/store/mz7lirsvz0b0s9wffi5ddcb1l90i11sv-ghc-8.2.2
/nix/store/1clgf3jww0d6dfjpy7blymgqmi4kric0-ghc-8.4.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: haskell.compiler.ghc822, haskell.compiler.ghc841

Partial log (click to expand)

<<ghc: 505275296 bytes, 87 GCs, 7926603/17230240 avg/max bytes residency (5 samples), 38M in use, 0.002 INIT (0.018 elapsed), 1.863 MUT (2.583 elapsed), 0.753 GC (0.880 elapsed) :ghc>>
"/nix/store/h2ldlvqzamhi0kdlw600dclzdc9xqnzi-ghc-8.2.1-binary/bin/ghc" -hisuf hi -osuf  o -hcsuf hc -static  -H32m -O -Wall   -package-db libraries/bootstrapping.conf  -this-unit-id text-1.2.3.0 -hide-all-packages -i -ilibraries/text/. -ilibraries/text/dist-boot/build -Ilibraries/text/dist-boot/build -ilibraries/text/dist-boot/build/./autogen -Ilibraries/text/dist-boot/build/./autogen -Ilibraries/text/include -Ilibraries/text/dist-boot/build/include   -optP-DHAVE_DEEPSEQ -optP-DINTEGER_GMP -optP-include -optPlibraries/text/dist-boot/build/./autogen/cabal_macros.h -package-id array-0.5.2.0 -package-id base-4.10.0.0 -package-id binary-0.8.5.1 -package-id deepseq-1.4.3.0 -package-id ghc-prim-0.5.1.0 -package-id bytestring-0.10.8.2 -package-id integer-gmp-1.0.1.0 -Wall -fwarn-tabs -funbox-strict-fields -O2 -XHaskell98   -no-user-package-db -rtsopts  -fno-warn-deprecated-flags      -odir libraries/text/dist-boot/build -hidir libraries/text/dist-boot/build -stubdir libraries/text/dist-boot/build    -c libraries/text/./Data/Text/Read.hs -o libraries/text/dist-boot/build/Data/Text/Read.o
<<ghc: 5667312536 bytes, 536 GCs, 35523100/66730136 avg/max bytes residency (15 samples), 180M in use, 0.002 INIT (0.018 elapsed), 17.694 MUT (20.213 elapsed), 9.216 GC (9.939 elapsed) :ghc>>
"/nix/store/h2ldlvqzamhi0kdlw600dclzdc9xqnzi-ghc-8.2.1-binary/bin/ghc" -hisuf hi -osuf  o -hcsuf hc -static  -H32m -O -Wall  -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header -package-db libraries/bootstrapping.conf  -this-unit-id ghc-8.4.1 -hide-all-packages -i -icompiler/backpack -icompiler/basicTypes -icompiler/cmm -icompiler/codeGen -icompiler/coreSyn -icompiler/deSugar -icompiler/ghci -icompiler/hsSyn -icompiler/iface -icompiler/llvmGen -icompiler/main -icompiler/nativeGen -icompiler/parser -icompiler/prelude -icompiler/profiling -icompiler/rename -icompiler/simplCore -icompiler/simplStg -icompiler/specialise -icompiler/stgSyn -icompiler/stranal -icompiler/typecheck -icompiler/types -icompiler/utils -icompiler/vectorise -icompiler/stage1/build -Icompiler/stage1/build -icompiler/stage1/build/./autogen -Icompiler/stage1/build/./autogen -Icompiler/. -Icompiler/parser -Icompiler/utils -Icompiler/stage1 -Icompiler/stage1/build/. -Icompiler/stage1/build/parser -Icompiler/stage1/build/utils -Icompiler/stage1/build/stage1    -optP-include -optPcompiler/stage1/build/./autogen/cabal_macros.h -package-id base-4.10.0.0 -package-id deepseq-1.4.3.0 -package-id directory-1.3.0.2 -package-id process-1.6.1.0 -package-id bytestring-0.10.8.2 -package-id binary-0.8.5.1 -package-id time-1.8.0.2 -package-id containers-0.5.10.2 -package-id array-0.5.2.0 -package-id filepath-1.4.1.2 -package-id template-haskell-2.13.0.0 -package-id hpc-0.6.0.3 -package-id transformers-0.5.5.0 -package-id ghc-boot-8.4.1 -package-id ghc-boot-th-8.4.1 -package-id ghci-8.4.1 -package-id unix-2.7.2.2 -package-id terminfo-0.4.1.1 -Wall -Wno-name-shadowing -Wnoncanonical-monad-instances -Wnoncanonical-monadfail-instances -Wnoncanonical-monoid-instances -this-unit-id ghc -XHaskell2010 -XNoImplicitPrelude -DSTAGE=1 -Rghc-timing  -Wcpp-undef  -no-user-package-db -rtsopts        -odir compiler/stage1/build -hidir compiler/stage1/build -stubdir compiler/stage1/build    -c compiler/utils/GraphPpr.hs -o compiler/stage1/build/GraphPpr.o
<<ghc: 699981912 bytes, 155 GCs, 10868841/21681624 avg/max bytes residency (6 samples), 56M in use, 0.002 INIT (0.014 elapsed), 2.759 MUT (3.735 elapsed), 1.171 GC (1.346 elapsed) :ghc>>
<<ghc: 610544856 bytes, 118 GCs, 11732193/26576320 avg/max bytes residency (6 samples), 59M in use, 0.002 INIT (0.014 elapsed), 2.221 MUT (3.002 elapsed), 1.179 GC (1.402 elapsed) :ghc>>
<<ghc: 748323120 bytes, 80 GCs, 12173329/28489952 avg/max bytes residency (5 samples), 62M in use, 0.002 INIT (0.014 elapsed), 3.041 MUT (4.144 elapsed), 1.095 GC (1.263 elapsed) :ghc>>
building of '/nix/store/46yqdamgpriiv91mnilg02lq7bmxm4dx-ghc-8.2.2.drv' timed out after 1800 seconds
building of '/nix/store/8sxgavkfr6j7jp4f5i017hp1svp9wj61-ghc-8.4.1.drv' timed out after 1800 seconds
�[31;1merror:�[0m build of '/nix/store/46yqdamgpriiv91mnilg02lq7bmxm4dx-ghc-8.2.2.drv', '/nix/store/8sxgavkfr6j7jp4f5i017hp1svp9wj61-ghc-8.4.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: haskell.compiler.ghc822, haskell.compiler.ghc841

Partial log (click to expand)

<<ghc: 269810328 bytes, 58 GCs, 13423608/31099696 avg/max bytes residency (6 samples), 70M in use, 0.003 INIT (0.003 elapsed), 0.964 MUT (1.756 elapsed), 0.870 GC (0.961 elapsed) :ghc>>
<<ghc: 2873473632 bytes, 166 GCs, 57636899/216831520 avg/max bytes residency (9 samples), 453M in use, 0.001 INIT (0.002 elapsed), 8.848 MUT (16.158 elapsed), 7.388 GC (8.289 elapsed) :ghc>>
"/nix/store/zx62zsywigqgq92q1ci4p4c2zlr8blra-ghc-8.2.1-binary/bin/ghc" -hisuf hi -osuf  o -hcsuf hc -static  -H32m -O -Wall  -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header -package-db libraries/bootstrapping.conf  -this-unit-id ghc-8.2.2 -hide-all-packages -i -icompiler/backpack -icompiler/basicTypes -icompiler/cmm -icompiler/codeGen -icompiler/coreSyn -icompiler/deSugar -icompiler/ghci -icompiler/hsSyn -icompiler/iface -icompiler/llvmGen -icompiler/main -icompiler/nativeGen -icompiler/parser -icompiler/prelude -icompiler/profiling -icompiler/rename -icompiler/simplCore -icompiler/simplStg -icompiler/specialise -icompiler/stgSyn -icompiler/stranal -icompiler/typecheck -icompiler/types -icompiler/utils -icompiler/vectorise -icompiler/stage1/build -Icompiler/stage1/build -icompiler/stage1/build/./autogen -Icompiler/stage1/build/./autogen -Icompiler/. -Icompiler/parser -Icompiler/utils -Icompiler/stage1    -optP-include -optPcompiler/stage1/build/./autogen/cabal_macros.h -package-id base-4.10.0.0 -package-id deepseq-1.4.3.0 -package-id directory-1.3.0.2 -package-id process-1.6.1.0 -package-id bytestring-0.10.8.2 -package-id binary-0.8.5.1 -package-id time-1.8.0.2 -package-id containers-0.5.10.2 -package-id array-0.5.2.0 -package-id filepath-1.4.1.2 -package-id template-haskell-2.12.0.0 -package-id hpc-0.6.0.3 -package-id transformers-0.5.2.0 -package-id ghc-boot-8.2.2 -package-id ghc-boot-th-8.2.2 -package-id ghci-8.2.2 -package-id hoopl-3.10.2.2 -package-id unix-2.7.2.2 -package-id terminfo-0.4.1.0 -Wall -fno-warn-name-shadowing -this-unit-id ghc -XHaskell2010 -DSTAGE=1 -Rghc-timing   -no-user-package-db -rtsopts       -odir compiler/stage1/build -hidir compiler/stage1/build -stubdir compiler/stage1/build    -c compiler/cmm/CmmSink.hs -o compiler/stage1/build/CmmSink.o
/nix/store/zx62zsywigqgq92q1ci4p4c2zlr8blra-ghc-8.2.1-binary/lib/ghc-8.2.1/bin/ghc: /nix/store/iclw0ry5bvhjxbmbb1hdphb6qmmyqswf-ncurses-6.1-abi5-compat/lib/libtinfo.so.5: no version information available (required by /nix/store/zx62zsywigqgq92q1ci4p4c2zlr8blra-ghc-8.2.1-binary/lib/ghc-8.2.1/bin/../haskeline-0.7.4.0/libHShaskeline-0.7.4.0-ghc8.2.1.so)
/nix/store/zx62zsywigqgq92q1ci4p4c2zlr8blra-ghc-8.2.1-binary/lib/ghc-8.2.1/bin/ghc: /nix/store/iclw0ry5bvhjxbmbb1hdphb6qmmyqswf-ncurses-6.1-abi5-compat/lib/libtinfo.so.5: no version information available (required by /nix/store/zx62zsywigqgq92q1ci4p4c2zlr8blra-ghc-8.2.1-binary/lib/ghc-8.2.1/bin/../ghc-8.2.1/libHSghc-8.2.1-ghc8.2.1.so)
/nix/store/zx62zsywigqgq92q1ci4p4c2zlr8blra-ghc-8.2.1-binary/lib/ghc-8.2.1/bin/ghc: /nix/store/iclw0ry5bvhjxbmbb1hdphb6qmmyqswf-ncurses-6.1-abi5-compat/lib/libtinfo.so.5: no version information available (required by /nix/store/zx62zsywigqgq92q1ci4p4c2zlr8blra-ghc-8.2.1-binary/lib/ghc-8.2.1/bin/../terminfo-0.4.1.0/libHSterminfo-0.4.1.0-ghc8.2.1.so)
<<ghc: 380015656 bytes, 67 GCs, 13926725/33608048 avg/max bytes residency (6 samples), 74M in use, 0.003 INIT (0.003 elapsed), 1.345 MUT (2.612 elapsed), 0.941 GC (1.045 elapsed) :ghc>>
<<ghc: 1802543712 bytes, 236 GCs, 23457213/69795320 avg/max bytes residency (8 samples), 151M in use, 0.001 INIT (0.002 elapsed), 6.197 MUT (13.203 elapsed), 2.046 GC (2.294 elapsed) :ghc>>
building of '/nix/store/5lgn8n3j2k6j7ag1v74r9szlzr4qj700-ghc-8.2.2.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/5lgn8n3j2k6j7ag1v74r9szlzr4qj700-ghc-8.2.2.drv', '/nix/store/x3r5c5vwqs3yjvd40df7jjis60v3rmkd-ghc-8.4.1.drv' failed

@shlevy shlevy merged commit 59a53aa into NixOS:staging Mar 26, 2018
@shlevy shlevy deleted the ghc-abi-depends-determinism branch March 26, 2018 17:41
@oxij
Copy link
Member

oxij commented Mar 28, 2018 via email

@shlevy
Copy link
Member Author

shlevy commented Mar 28, 2018

@oxij Fantastic 😂 Looking into it.

@shlevy
Copy link
Member Author

shlevy commented Mar 28, 2018

OK, uploading the patch to tarballs.nixos.org

@shlevy
Copy link
Member Author

shlevy commented Mar 28, 2018

Fixed in fbe8deb and ba717c5

@oxij
Copy link
Member

oxij commented Mar 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants