You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, to create a TCPSocket connecting to a Socket::IPAddress, you have to access host and port properties and pass them in as separate arguments:
From my perspective it helps avoid duplicating address.address, address.port in constructors for TCP sockets. If nothing else, this is just a missing piece that completes the API: Socket classes already return Socket::Address from #local_address and #remote_address, so it makes sense to also use this type to create a socket. It is the natural data type to describe a socket address, the string (+ int) overloads are essentially just short cuts to avoid having to create a IPAddress/UNIXAddress manually when creating a socket.
If it would be preferable to always use host+port/path individually, why does Socket::Address exists anyway? The socket methods could also return a tuple and we'd just need a converter method from LibC address pointer.
I don't think that would make any sense and I like having the address type, although it is probably not used that much. But if this type exists, you should be able to use it to create a socket.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
straight-shoota
deleted the
jm/feature/initialize-socket-server-with-address
branch
Currently, to create a
TCPSocketconnecting to aSocket::IPAddress, you have to access host and port properties and pass them in as separate arguments:with this PR, the socket address can be used as a constructor argument directly:
Overloads have been added for:
TCPServer.newTCPServer.openTCPSocket.newTCPSocket.openAnd with
Socket::UNIXAddress:UNIXServer.newUNIXServer.openUNIXSocket.newUNIXSocket.openUDPSocket#bindandUDPSocket#connectalready have overloads accepting aSocket::IPAddress.