Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python27Packages.rootpy: fix build (tests) #38441

Merged
merged 1 commit into from Apr 4, 2018
Merged

python27Packages.rootpy: fix build (tests) #38441

merged 1 commit into from Apr 4, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Apr 4, 2018

Motivation for this change

Build failed because tests were not run properly. Fix them and skip a few problematic tests.

/cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
python27Packages.rootpy: fix build (tests)
4e870f1 
run tests properly, skip problematic tests
@xeji xeji requested a review from FRidh as a code owner April 4, 2018 20:39
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.rootpy

Partial log (click to expand)

.
.
                              [100%]


============================== 5 tests deselected ==============================

============= 120 passed, 1 skipped, 5 deselected in 67.24 seconds =============

/nix/store/27qbf853g7ajnl8kmwmnha4nmr3l792z-python2.7-rootpy-1.0.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.rootpy

Partial log (click to expand)

rootpy/tree/tests/test_cut.py .                                          [ 81%]
rootpy/tree/tests/test_tree.py ............                              [ 91%]
rootpy/tree/tests/test_treetypes.py .                                    [ 92%]
rootpy/utils/tests/test_ext_glob.py .....                                [ 96%]
rootpy/utils/tests/test_hook.py ..                                       [ 98%]
rootpy/utils/tests/test_module_facade.py ..                              [100%]

============================== 5 tests deselected ==============================
============ 120 passed, 1 skipped, 5 deselected in 233.30 seconds =============
/nix/store/ah88xwq1js1jb22bknryjk08bcbkf64i-python2.7-rootpy-1.0.1

@dotlambda dotlambda merged commit 837dd2e into NixOS:master Apr 4, 2018
@dotlambda
Copy link
Member

Thanks!

@dotlambda
Copy link
Member

Backported in becbe4d.

@xeji xeji deleted the p/rootpy branch April 8, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @dotlambda