Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: requirement parser would ignore requirements specified with url #38448

Merged
merged 3 commits into from
Apr 5, 2018
Merged

home-assistant: requirement parser would ignore requirements specified with url #38448

merged 3 commits into from
Apr 5, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

parse-requirements.py would ignore packages specified at url. Now we strip the URL so the package can still be used if found in pythonPackages.

If the package in question then works with hass is something completely different...

Usual "non-python-programmer" caveat applies.

Cc: @dotlambda @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg requested review from FRidh and dotlambda and removed request for FRidh April 5, 2018 07:38
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

copying path '/nix/store/i238maj04mcw5cxj66fz58v66mvsx95x-python3.6-cffi-1.11.5-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/5f2fra67ard6n1isrfr7k68p76ncnvf6-python3.6-cryptography-2.1.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/38vvlrpa32sl1qvajw871xcxlrq2mlv6-python3.6-aiohttp-3.0.6' from 'https://cache.nixos.org'...
copying path '/nix/store/9jp1dklf2d8w7gbhzksba7pbs7jbhggy-python3.6-pyOpenSSL-17.5.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/iyd0ajzv5mi5rg1cfza1szzay78pf4g7-python3.6-urllib3-1.22' from 'https://cache.nixos.org'...
copying path '/nix/store/axxin6nllzsgvsrhqswrhgpvp9mvc158-python3.6-aiohttp-cors-0.7.0' from 'https://cache.nixos.org'...
copying path '/nix/store/f4qgdvvhjxg5yxynmhz02k7528irnga9-python3.6-requests-2.18.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/lz0mpfkfl3pfccn6py79dmix2pzglbzh-python3.6-astral-1.5' from 'https://cache.nixos.org'...
copying path '/nix/store/j86zmva0b4rp9lb55bn8fa1hc4vlc6ff-homeassistant-0.65.5' from 'https://cache.nixos.org'...
/nix/store/j86zmva0b4rp9lb55bn8fa1hc4vlc6ff-homeassistant-0.65.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)


 98 2386k   98 2362k    0     0  1181k
0  0:00:02  0:00:02 --:--:-- 1089k

100 2386k
 100 2386k    0     0  1193k      0  0
:00:02  0:0
0:02 --:
--:-- 10
70k

/nix/store/fiiihcsnk40kj0x09kc10nkckrm3mn3f-homeassistant-0.65.5

@dotlambda
Copy link
Member

@peterhoeg I added an inline comment about what your addition does and support for requirements that are commented out.

@peterhoeg
Copy link
Member Author

Nice! Much better.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

/nix/store/j86zmva0b4rp9lb55bn8fa1hc4vlc6ff-homeassistant-0.65.5

@dotlambda dotlambda merged commit f8a41e5 into NixOS:master Apr 5, 2018
@peterhoeg peterhoeg deleted the f/parser branch April 5, 2018 08:20
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

/nix/store/fiiihcsnk40kj0x09kc10nkckrm3mn3f-homeassistant-0.65.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @GrahamcOfBorg @dotlambda