Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godot: add application metadata and man page to share #38444

Merged
merged 1 commit into from Apr 5, 2018
Merged

godot: add application metadata and man page to share #38444

merged 1 commit into from Apr 5, 2018

Conversation

coreyoconnor
Copy link
Contributor

@coreyoconnor coreyoconnor commented Apr 4, 2018 •
edited

Motivation for this change
  1. missing "Godot" in desktop application menu.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 5, 2018

@GrahamcOfBorg build godot

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: godot

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: godot

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92
Copy link
Member

Mic92 commented Apr 5, 2018

@coreyoconnor can you add yourself to ofborg? NixOS/ofborg#152

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: godot

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/k9awnf0w7kqb8vx5j4302yc275hr0nwy-godot-3.0.2
shrinking /nix/store/k9awnf0w7kqb8vx5j4302yc275hr0nwy-godot-3.0.2/bin/godot
gzipping man pages under /nix/store/k9awnf0w7kqb8vx5j4302yc275hr0nwy-godot-3.0.2/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/k9awnf0w7kqb8vx5j4302yc275hr0nwy-godot-3.0.2/bin
patching script interpreter paths in /nix/store/k9awnf0w7kqb8vx5j4302yc275hr0nwy-godot-3.0.2
checking for references to /tmp/nix-build-godot-3.0.2.drv-0 in /nix/store/k9awnf0w7kqb8vx5j4302yc275hr0nwy-godot-3.0.2...
/nix/store/k9awnf0w7kqb8vx5j4302yc275hr0nwy-godot-3.0.2

@coreyoconnor coreyoconnor mentioned this pull request Apr 5, 2018
Merged
@Mic92 Mic92 merged commit 583a851 into NixOS:master Apr 5, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 5, 2018

18.03:

[detached HEAD 0504cbe] godot: add application metadata and man page to share.
Author: Corey O'Connor coreyoconnor@gmail.com
Date: Wed Apr 4 16:14:40 2018 -0700
1 file changed, 13 insertions(+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coreyoconnor @Mic92 @GrahamcOfBorg